opendev/system-config
Code Issues Proposed changes

Stop giving -f and -e lines a pass in requirements

Browse Source 
We had exclusions in the testing to allow for legacy issues and a
migration path. That's not cutting it any more and has allowed
a new -f line to slip in.

Be more strict.

Change-Id: I7c1debdd9307135efc68b402bf830a44c914d3fe
This commit is contained in:
Monty Taylor 2014-05-01 13:41:34 -07:00
parent f1cd8cceaf
commit a9f7eb4bab
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/openstack_project/files/slave_scripts/project-requirements-change.py
View File

@ -99,9 +99,7 @@ class RequirementsList(object):
line = line[:line.find('#')]
line = line.strip()
if (not line or
line.startswith('http://tarballs.openstack.org/') or
line.startswith('-e') or
line.startswith('-f')):
line.startswith('http://tarballs.openstack.org/')):
continue
req = pkg_resources.Requirement.parse(line)
if (not ignore_dups and strict and req.project_name.lower()