opendev/system-config
Code Issues Proposed changes

doc/gerrit : update to submit-requirements

Browse Source 
Update the MaxWithBlock function in the default labels to a new-format
submit-requirement.

Change-Id: I9887c4949fe375db0397bf273820e57a9d539749
This commit is contained in:
Ian Wienand 2023-03-03 11:08:22 +11:00
parent 22506e5682
commit b37ec6632a
No known key found for this signature in database
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
doc/source/gerrit.rst
View File

@ -295,27 +295,40 @@ Next, edit ``project.config`` to look like::
[label "Code-Review"] [label "Code-Review"]
abbreviation = R abbreviation = R
copyCondition = changekind:TRIVIAL_REBASE OR is:MIN copyCondition = changekind:TRIVIAL_REBASE OR is:MIN
function = MaxWithBlock function = NoBlock
value = -2 Do not merge value = -2 Do not merge
value = -1 This patch needs further work before it can be merged value = -1 This patch needs further work before it can be merged
value = 0 No score value = 0 No score
value = +1 Looks good to me, but someone else must approve value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me (core reviewer) value = +2 Looks good to me (core reviewer)
[submit-requirement "Code-Review"]
description = Code reviewed
submittableIf = label:Code-Review=MAX and -label:Code-Review=MIN
canOverrideInChildProjects = true
[label "Verified"] [label "Verified"]
function = MaxWithBlock function = NoBlock
value = -2 Fails value = -2 Fails
value = -1 Doesn't seem to work value = -1 Doesn't seem to work
value = 0 No score value = 0 No score
value = +1 Works for me value = +1 Works for me
value = +2 Verified value = +2 Verified
[submit-requirement "Verified"]
description = Code verified by Zuul
submittableIf = label:Verified=MAX and -label:Verified=MIN
[label "Workflow"] [label "Workflow"]
function = MaxWithBlock function = NoBlock
value = -1 Work in progress value = -1 Work in progress
value = 0 Ready for reviews value = 0 Ready for reviews
value = +1 Approved value = +1 Approved
[submit-requirement "Workflow"]
description = Approved by core member
submittableIf = label:Workflow=MAX and -label:Workflow=MIN
[plugin "its-storyboard"] [plugin "its-storyboard"]
enabled = true enabled = true