opendev/system-config
Code Issues Proposed changes

a more visually compact template for recheck

Browse Source 
the recheck template was very expansive, which often meant that a
busy bug would take over the entire default window.

Instead of displaying things in <li>, make them lists on a single line.

Adjust whitespace on h3s so that they visually are attached to the
item they explain. Default h* spacing rules in html are actually
typically backwards, and require you to put a visual artifact above
them to imply the grouping you want.

Put a (closed) at the end of the title about bugs that are closed, to
give some indication about why they were shifted down the list.

It also deletes some errant trailing spaces, sorry about the unrelated
change there, but my emacs is configured to do that on every save.

Change-Id: I7869aa8a5b41f2f8826f61b8052933de659cb6cd
Reviewed-on: https://review.openstack.org/23341
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
This commit is contained in:
Sean Dague 2013-03-02 08:39:00 -05:00 committed by Jenkins
parent 30a62df56f
commit b8764f9551
1 changed files with 22 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
modules/openstack_project/files/zuul/scoreboard.html
View File

@ -22,6 +22,14 @@
<link rel="stylesheet" href="http://openstack.org/themes/openstack/css/home.css" type="text/css" media="screen, projection, print"/>
<link rel="stylesheet" type="text/css" href="http://openstack.org/themes/openstack/css/main.css" />
<style type="text/css">
h3.subhead {
border: none;
margin-bottom: 0.2em;
padding-top: 1.5em;
}
</style>
</HEAD>
<BODY>
@ -49,27 +57,21 @@
<div class="container">
<h1>Bugs Causing Rechecks</h1>
<br/>
<div py:for="bug in bugs">
<h3 class="subhead">
<a href="https://code.launchpad.net/bugs/${bug['number']}">
Bug ${bug.number}: ${bug.title}</a>
<py:if test="bug.is_closed()">(closed)</py:if>
</h3>
First seen: ${bug.first_seen.strftime("%Y-%m-%d %H:%M:%S")} UTC<br/>
Last seen: ${bug.last_seen.strftime("%Y-%m-%d %H:%M:%S")} UTC<br/>
Rechecks: ${len(bug.hits)}<br/>
Affecting projects:
<ul>
<li py:for="project in bug.projects">
${project}
</li>
</ul>
Affecting projects: ${', '.join(bug.projects)}<br/>
Affecting changes:
<ul>
<li py:for="change in bug.changes">
<a href="https://review.openstack.org/${change}"> ${change} </a>
</li>
</ul>
<span py:for="i, change in enumerate(bug.changes)">
<a href="https://review.openstack.org/${change}"
>${change}</a><span py:if="i+1 != len(bug.changes)" py:replace="','"/>
</span>
</div>
</div>
@ -116,4 +118,3 @@
</div>
</BODY>
</html>