opendev/system-config
Code Issues Proposed changes

Fix the gerrit-host used by jeepyb config

Browse Source 
This template was previously set to use the local hosts fqdn for the
jeepyb gerrit-host config item. Now that we've switched to indexed hosts
for review.o.o that ends up as review01.openstack.org.

This would work fine for network connectivity to the ssh server and
otherwise we wouldn't notice except that this is the value we write into
the .gitreview files. To make them more accurate switch to
review.openstack.org as the explicit value.

Note I considered making this configurable but we already assume so many
other openstack specific values in this file I don't think its super
necessary.

Change-Id: I065af01b2793639453562d924e58ba7c769dcd38
This commit is contained in:
Clark Boylan 2018-05-03 14:33:51 -07:00
parent a522c0a8d1
commit c25a3bec74
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openstack_project/templates/review.projects.ini.erb
View File

@ -3,7 +3,7 @@ homepage=http://openstack.org
acl-dir=/home/gerrit2/acls
local-git-dir=<%= @local_git_dir %>
jeepyb-cache-dir=<%= @jeepyb_cache_dir %>
gerrit-host=<%= @fqdn %>
gerrit-host=review.openstack.org
gerrit-user=openstack-project-creator
gerrit-committer=OpenStack Project Creator <openstack-infra@lists.openstack.org>
gerrit-key=<%= @ssh_project_key %>