From d4910d18c0514dcda5a7eeaa9008dbfab3a39c23 Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Wed, 29 Jun 2022 11:25:24 -0700
Subject: [PATCH] Move gitea partial clone test

This moves the gitea partial clone test from our setup playbook into
testinfra/test_gitea.py. We should avoid asserting too much state and
behavior in the ansible as it makes the split between testinfra and
ansible more confusing. To address this we move this behavior check into
testinfra where it belongs.

Change-Id: I6a649bc380f850425c51e9b4632c798a23ab0e0e
---
 playbooks/test-gitea.yaml | 4 ----
 testinfra/test_gitea.py   | 9 +++++++++
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/playbooks/test-gitea.yaml b/playbooks/test-gitea.yaml
index 86b48a4b35..a3fa8a72f4 100644
--- a/playbooks/test-gitea.yaml
+++ b/playbooks/test-gitea.yaml
@@ -57,10 +57,6 @@
       # user.
       become: true
       become_user: zuul
-    - name: Clone system-config to check that partial clones aren't breaking stuff
-      shell: |
-        cd /tmp
-        GIT_SSL_NO_VERIFY=1 git clone --filter=blob:none https://localhost:3081/opendev/system-config test-system-config-clone
 
 - name: Run rename playbook
   import_playbook: rename_repos.yaml
diff --git a/testinfra/test_gitea.py b/testinfra/test_gitea.py
index 5e83a37878..594905349d 100644
--- a/testinfra/test_gitea.py
+++ b/testinfra/test_gitea.py
@@ -86,6 +86,15 @@ def test_project_clone(host):
     assert "Cloning into '/tmp/disk-image-builder'..." in cmd.stderr
     assert cmd.succeeded
 
+def test_partial_project_clone(host):
+    cmd = host.run(
+        'GIT_SSL_NO_VERIFY=1 '
+        'git clone --filter=blob:none '
+        'https://localhost:3081/opendev/system-config '
+        '/tmp/test-system-config-clone')
+    assert "Cloning into '/tmp/test-system-config-clone'..." in cmd.stderr
+    assert cmd.succeeded
+
 def test_gitea_screenshots(host):
 
         shots = (