opendev/system-config
Code Issues Proposed changes

pip: use latest instead of upgrade

Browse Source 
I'm not sure if this is clearer or not (which is why I proposed it
separately here).

From inspection of the code, adding "state: latest" just means Ansible
runs "install -U" ... which is pretty much the same thing as adding
--upgrade.  Which is clearer, I'm not sure?

Change-Id: I6e31523686555e33d062f3b05f2385d7e21e2620
This commit is contained in:
Ian Wienand 2022-12-06 16:25:30 +11:00
parent 4fa8d2dd39
commit c921954649
No known key found for this signature in database
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/roles/create-venv/tasks/main.yaml
View File

@ -49,6 +49,6 @@
when: _venv_requirements_txt.changed when: _venv_requirements_txt.changed
pip: pip:
requirements: '{{ create_venv_path }}/requirements-venv.txt' requirements: '{{ create_venv_path }}/requirements-venv.txt'
extra_args: '--upgrade' state: latest
virtualenv: '{{ create_venv_path }}' virtualenv: '{{ create_venv_path }}'
virtualenv_command: '/usr/bin/python3 -m venv' virtualenv_command: '/usr/bin/python3 -m venv'

4
playbooks/roles/install-ansible/tasks/main.yaml
View File

@ -67,10 +67,10 @@
when: _requirements_updated.changed when: _requirements_updated.changed
pip: pip:
requirements: '/usr/ansible-venv/requirements.txt' requirements: '/usr/ansible-venv/requirements.txt'
virtualenv: '/usr/ansible-venv'
# Always upgrade because only called in response to # Always upgrade because only called in response to
# requirements.txt changes. # requirements.txt changes.
extra_args: '--upgrade' state: latest
virtualenv: '/usr/ansible-venv'
# From Ansible 2.10 >= most of the fun stuff is in collections. Clone # From Ansible 2.10 >= most of the fun stuff is in collections. Clone
# our required collections here. Note this is only for our testing of # our required collections here. Note this is only for our testing of