Remove envinject from javascript

Instead source the properties into the environment.

The macros js-build and assert-no-extra-files did not require any
of the properties and as such do not require updating.

Change-Id: I3297b2d9d503425e5d586d83eaab4f6c8e65039a

modules/openstack_project/files/jenkins_job_builder/config/javascript.yaml

@@ -10,11 +10,6 @@
     builders:
       - revoke-sudo
       - gerrit-git-prep
-      - shell: |
-          #!/bin/bash -xe
-          /usr/local/jenkins/slave_scripts/version-properties.sh
-      - inject:
-          properties-file: version.properties
       - js-build:
           command: 'test'
           envlist: 'grunt'
@@ -47,11 +42,6 @@
     builders:
       - revoke-sudo
       - gerrit-git-prep
-      - shell: |
-          #!/bin/bash -xe
-          /usr/local/jenkins/slave_scripts/version-properties.sh
-      - inject:
-          properties-file: version.properties
       - js-build:
           command: 'build'
           envlist: 'grunt'
@@ -59,6 +49,8 @@
           project: '{name}'
       - shell: |
           #!/bin/bash -xe
+          /usr/local/jenkins/slave_scripts/version-properties.sh
+          source version.properties
 
           # Clean/create a tarball directory
           rm -rf tarballs