opendev/system-config
Code Issues Proposed changes

Merge "Filter nonexistent groups in who-approves.py"

Browse Source
This commit is contained in:
Jenkins 2016-07-01 13:43:38 +00:00 committed by Gerrit Code Review
commit e06b365bb9
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/who-approves.py
View File

@ -124,9 +124,14 @@ for team in projects:
repos[repo]['tags'] = \ repos[repo]['tags'] = \
projects[team]['deliverables'][deli]['tags'] projects[team]['deliverables'][deli]['tags']
for aprv_group in aprv_groups.keys(): for aprv_group in aprv_groups.keys():
aprv_groups[aprv_group] = json.loads(requests.get( # It's possible for built-in metagroups in recent Gerrit releases to
gerrit_url + group_path % all_groups[aprv_group]['id'], # appear in ACLs but not in the groups list
auth=gerrit_auth).text[4:]) if aprv_group in all_groups:
aprv_groups[aprv_group] = json.loads(requests.get(
gerrit_url + group_path % all_groups[aprv_group]['id'],
auth=gerrit_auth).text[4:])
else:
sys.stderr.write('Ignoring nonexistent "%s" group.\n' % aprv_group)
for repo in repos: for repo in repos:
for aprv_group in repos[repo]['approvers'].keys(): for aprv_group in repos[repo]['approvers'].keys():
for approver in aprv_groups[aprv_group]: for approver in aprv_groups[aprv_group]: