opendev/system-config
Code Issues Proposed changes

Add titles to the times on zuul status's page

Browse Source 
Currently there are two times displayed on zuuls status page
(http://status.openstack.org/zuul/). It is not immediately obvious
what these times represent.

This change adds a title to each time so that when hovered over a
description is available.

Change-Id: I17563851e76dcc09fd7d71e8946622ba24fc3ea5
This commit is contained in:
Joshua Hesketh 2014-03-13 13:42:08 +11:00
parent 6894c3ffaa
commit e08ec6581d
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
modules/openstack_project/files/zuul/status.js
View File

@ -223,6 +223,14 @@ function safe_id(id) {
function format_change(change, change_queue) { function format_change(change, change_queue) {
var html = '<tr>'; var html = '<tr>';
safe_change_id = safe_id(change['id']);
display = $('#expandByDefault').is(':checked');
collapsed_index = window.zuul_collapsed_exceptions.indexOf(safe_change_id);
if (collapsed_index > -1) {
/* listed as an exception to the current default */
display = !display;
}
for (var i=0; i<change_queue['_tree_columns']; i++) { for (var i=0; i<change_queue['_tree_columns']; i++) {
var cls = 'tree'; var cls = 'tree';
if (i < change['_tree'].length && change['_tree'][i] !== null) { if (i < change['_tree'].length && change['_tree'][i] !== null) {
@ -253,22 +261,14 @@ function format_change(change, change_queue) {
} }
html += '<td class="change-container">'; html += '<td class="change-container">';
html += '<div class="change" id="' + safe_id(change['id']) + '">' + html += '<div class="change" id="' + safe_change_id + '">' +
'<div class="header" onClick="toggle_display_jobs(event, this)" ' + '<div class="header" onClick="toggle_display_jobs(event, this)" ' +
'onmouseover="$(this).addClass(\'hover\')" ' + 'onmouseover="$(this).addClass(\'hover\')" ' +
'onmouseout="$(this).removeClass(\'hover\')">'; 'onmouseout="$(this).removeClass(\'hover\')">';
// Row #1 of the header (project and remaining time)
html += '<span class="project">' + change['project'] + '</span>'; html += '<span class="project">' + change['project'] + '</span>';
html += '<span class="time" title="Remaining Time">';
display = $('#expandByDefault').is(':checked');
safe_change_id = safe_id(change['id']);
collapsed_index = window.zuul_collapsed_exceptions.indexOf(safe_change_id);
if (collapsed_index > -1) {
/* listed as an exception to the current default */
display = !display;
}
html += '<span class="time">';
html += format_time(change['remaining_time'], true); html += format_time(change['remaining_time'], true);
html += '</span><br/>'; html += '</span><br/>';
@ -293,7 +293,8 @@ function format_change(change, change_queue) {
html += '&nbsp;'; html += '&nbsp;';
} }
html += '</span>'; html += '</span>';
html += '<span class="time">' + format_enqueue_time(change['enqueue_time']) + '</span>'; html += '<span class="time" title="Queued Time">';
html += format_enqueue_time(change['enqueue_time']) + '</span>';
html += '</div>'; html += '</div>';