opendev/system-config
Code Issues Proposed changes

Cleanup openstack_project::jenkins.

Browse Source 
There were a few extra []'s and some missing commas. Also leave a
comment that 'gerrig' is not a typo.

Change-Id: I04a5fa026fbd715ac370e070ff75b474fbe6335f
Reviewed-on: https://review.openstack.org/14414
Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Approved: James E. Blair <corvus@inaugust.com>
Reviewed-by: James E. Blair <corvus@inaugust.com>
Tested-by: Jenkins
This commit is contained in:
Clark Boylan 2012-10-12 15:26:05 -07:00 committed by Jenkins
parent 274489ab9e
commit f304ba02fd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/openstack_project/manifests/jenkins.pp
View File

@ -8,7 +8,7 @@ class openstack_project::jenkins (
) {
class { 'openstack_project::server':
iptables_public_tcp_ports => [80, 443, 4155],
sysadmins => $sysadmins
sysadmins => $sysadmins,
}
$vhost_name = 'jenkins.openstack.org'
@ -27,7 +27,7 @@ class openstack_project::jenkins (
if manage_jenkins_jobs == true {
class { '::jenkins::job_builder':
url => "https://${vhost_name}/",
username => 'gerrig',
username => 'gerrig', # This is not a typo, well it isn't anymore.
password => $jenkins_jobs_password,
}
@ -37,13 +37,13 @@ class openstack_project::jenkins (
group => 'root',
mode => '0755',
recurse => true,
source => ['puppet:///modules/openstack_project/jenkins_job_builder/config'],
notify => Exec['jenkins_jobs_update']
source => 'puppet:///modules/openstack_project/jenkins_job_builder/config',
notify => Exec['jenkins_jobs_update'],
}
file { '/etc/default/jenkins':
ensure => present,
source => 'puppet:///modules/openstack_project/jenkins/jenkins.default'
source => 'puppet:///modules/openstack_project/jenkins/jenkins.default',
}
}
}