From fca20ebe840f37571894995acf1f7a4862e34a28 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Fri, 13 Apr 2018 20:14:09 +0000 Subject: [PATCH] Comment on linked stories for review state changes Configure the its-storyboard Gerrit plugin to leave comments with hyperlinks on stories mentioned in a change's commit message footer whenever that change gets a new patchset, or is abandoned or merged. This now must be explicitly configured for the version of the plugin used with newer Gerrit (circa 2.13). Change-Id: I14dea61a906c4b267145dce6911a10d8075b4ba9 --- modules/openstack_project/manifests/review.pp | 9 +++++++++ modules/openstack_project/manifests/review_dev.pp | 9 +++++++++ 2 files changed, 18 insertions(+) diff --git a/modules/openstack_project/manifests/review.pp b/modules/openstack_project/manifests/review.pp index 034bd36b81..100499cb26 100644 --- a/modules/openstack_project/manifests/review.pp +++ b/modules/openstack_project/manifests/review.pp @@ -191,7 +191,16 @@ class openstack_project::review ( url => 'https://storyboard.openstack.org', }, ], + # See https://gerrit.googlesource.com/plugins/its-storyboard + # /+/stable-2.13/src/main/resources/Documentation + # /quick-install-guide.md#its_actions_its_actionsconfigure-its-actions + # for documentation on these options. its_rules => [ + { + name => 'comment-on-status-update', + event_type => 'patchset-created,change-abandoned,change-restored,change-merged', + action => 'add-standard-comment', + }, { name => 'change_abandoned', event_type => 'change-abandoned', diff --git a/modules/openstack_project/manifests/review_dev.pp b/modules/openstack_project/manifests/review_dev.pp index d6f3c31e17..6239bdcb2c 100644 --- a/modules/openstack_project/manifests/review_dev.pp +++ b/modules/openstack_project/manifests/review_dev.pp @@ -144,11 +144,20 @@ class openstack_project::review_dev ( url => 'https://storyboard-dev.openstack.org', }, ], + # See https://gerrit.googlesource.com/plugins/its-storyboard + # /+/stable-2.13/src/main/resources/Documentation + # /quick-install-guide.md#its_actions_its_actionsconfigure-its-actions + # for documentation on these options. its_rules => [ { name => 'LOG', action => 'log-event error', }, + { + name => 'comment-on-status-update', + event_type => 'patchset-created,change-abandoned,change-restored,change-merged', + action => 'add-standard-comment', + }, { name => 'change_abandoned', event_type => 'change-abandoned',