202614e155
Consider whitespace changes significant enough not to reapply code reviews, but still comment if that's all which changed between patchsets. This addresses bug 1057506. * modules/openstack_project/files/gerrit/scripts/trivial_rebase.py (GetPatchId): Add a flag called consider_whitespace, but defaulting to False so as to preserve default behavior of the module. Add conditional behavior to replace all spaces and tabs with percent signs before calculating the patch-id hash. (Main): Add a --whitespace command-line option to turn on whitespace change checking. If enabled and if normal GetPatchId calls return a match, re-run with consider_whitespace set to True and apply a comment to the new patchset in Gerrit if the result is non-matching. * modules/openstack_project/templates/gerrit_patchset-created.erb: Add --whitespace to the trivial_rebase.py invocation, enabling whitespace checking. Change-Id: I89c479614a637717cf515a5d3f6d03b5f7830581 Reviewed-on: https://review.openstack.org/13775 Reviewed-by: James E. Blair <corvus@inaugust.com> Reviewed-by: Clark Boylan <clark.boylan@gmail.com> Reviewed-by: Paul Belanger <paul.belanger@polybeacon.com> Approved: Monty Taylor <mordred@inaugust.com> Reviewed-by: Monty Taylor <mordred@inaugust.com> Tested-by: Jenkins
12 lines
560 B
Plaintext
Executable File
12 lines
560 B
Plaintext
Executable File
#!/bin/sh
|
|
|
|
# Use timeout to kill any process running longer than 10 minutes.
|
|
timeout -k 2m 10m python /usr/local/gerrit/scripts/update_blueprint.py patchset-created "$@"
|
|
timeout -k 2m 10m python /usr/local/gerrit/scripts/update_bug.py patchset-created "$@"
|
|
timeout -k 2m 10m python /usr/local/gerrit/scripts/notify_doc_impact.py patchset-created "$@"
|
|
timeout -k 2m 10m python /usr/local/gerrit/scripts/trivial_rebase.py \
|
|
patchset-created \
|
|
--whitespace \
|
|
--private-key-path=<%= ssh_host_key %> \
|
|
--role-user=<%= trivial_rebase_role_id %> "$@"
|