Add Puppet syntax checks to catch any errors that would have
otherwise not been discovered by missing rspec tests. Syntax checks
also ensure that ERB templates are syntactically correct.
Add Puppet lint checks to improve quality and uniformity.
Puppet lint jobs are marked as non-voting. It would otherwise
block all changes from being merged until we fix every lint errors
which isn't possible in the short-term. Puppet lint will be
an ongoing work for the following weeks and months.
Change-Id: I991f6c1179113dd241dab4679a27a2aa42936c66
Reviewed-on: https://review.openstack.org/32663
Reviewed-by: James E. Blair <corvus@inaugust.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Reviewed-by: Elizabeth Krumbach Joseph <lyz@princessleia.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins
c7ebbbed16