From 149904321937761097d75f939dcd2b795abf7932 Mon Sep 17 00:00:00 2001 From: "Mark T. Voelker" Date: Thu, 11 Jun 2015 14:28:20 -0400 Subject: [PATCH] Re-introduce test removal clause In fd6aca6 [1] we changed rule D302 in HACKING so that tests which never met DefCore criteria in the first place could never be removed from the .next.json file (meaning that the flag would stay in place indefinitely and the test would be re-evaluated at the start of every DefCore cycle forever). Per discussion at the Flag.3 meeting [2], it seems that many Committee members feel that this was an oversite during review and that it would preferable for such tests to be removed in the interest of reducing clutter and avoiding spending a lot of cycles re-evaluating an ever-growing list of tests that are unlikely to ever meet DefCore criteria. This patch re-inroduces the clause allowing such tests to be removed. [1] https://review.openstack.org/#/c/185158/ [2] http://eavesdrop.openstack.org/meetings/defcore/2015/defcore.2015-06-11-01.02.html Change-Id: Id63956e9679562ad2c2ee5ec6b6d49cc80dfa6f0 --- HACKING.rst | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/HACKING.rst b/HACKING.rst index 50e05fbf..321c041b 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -17,17 +17,19 @@ DefCore Specific Commandments once approved by the Board. Therefore if you desire to flag a test, in an approved capability list, add a "flagged" block to the test. Do _not_ remove it from the "tests" section. -- [D302] If a test is found to not meet the DefCore Flagging Criteria - defined in this document after the Board has approved a Guideline, +- [D302] If a Capability is found to not meet the `Core Criteria + <./process/CoreCriteria.rst>`_ after the Board has approved a Guideline, the corresponding tests should have a "flagged" block added to the the relevant tests in the "tests" section of the relevant Board-approved - Guidelines. - - See [D307] for details about format requirements. - - See [D308] for conditions on also adding to the .next.json. + Guidelines. The tests should also be removed from the "tests" section of + the .next.json file. + - See [D307] for details about the flagged block - [D303] Tests that are found to inadequately test the underlying - Capability, due to bugs or design flaws, should have a "flagged" + Capability due to bugs or design flaws, should have a "flagged" block added to the section for the test in the "tests" section of the most recent Board-approved Guideline. + - See [D307] for details about the flagged block + - See [D308] for conditions on also adding to the .next.json. - [D304] Before the Board approves the capabilities listed in the .next.json file, a committee member will submit a patch that copies the .next.json file to an appropriately named new file, updates the