From 23dc48cc02c14c6db1d18a3e2e1b6cd5673dbd60 Mon Sep 17 00:00:00 2001
From: Matt Riedemann <mriedem.os@gmail.com>
Date: Thu, 5 Oct 2017 22:04:20 -0400
Subject: [PATCH] 2018.1 scoring: add compute-keypairs-create-type

This proposes scoring for the 2018.1 guidelines to include
the compute capability to create keypairs with a specified
type.

This microversion is important for Windows guests since it
allows the creation or import of x509 keypairs.

Notes:

- This feature is based on the compute API 2.2 microversion
  and was introduced in the Kilo release:

  https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id2

  https://developer.openstack.org/api-ref/compute/#create-or-import-keypair

- This feature is considered widely deployed since it is
  not configurable or backend-specific.

- It is considered not used by tools given it depends on
  those tools supporting compute API microversions, and it
  is assumed that most tools are still lacking in this area.

- This capability is discoverable since client code can
  determine if the microversion is available on the server
  via version discovery, i.e. compute-list-api-versions.

- While this feature was in the last release, it is not
  considered "required" since microversions are opt-in per
  request by the client.

  NOTE: Since this is the first proposed capability that
  depends on a microversion, it is assumed that the definition
  of what "required" means will need some adjusting to account
  for weighing microversion-based capabilities differently.

- There is an existing Tempest test for this microversion
  with id 89d59d43-f735-441a-abcf-0601727f47b6.

Change-Id: I62554618e38f3f7ca1b508387a1eef190cdcef63
---
 next.json                              | 23 +++++++++++++++++++++++
 working_materials/scoring.txt          |  1 +
 working_materials/tabulated_scores.csv |  1 +
 3 files changed, 25 insertions(+)

diff --git a/next.json b/next.json
index 52ec7482..bcc746ff 100644
--- a/next.json
+++ b/next.json
@@ -71,6 +71,7 @@
         "volumes-v2-upload"
       ],
       "advisory": [
+        "compute-keypairs-create-type",
         "identity-v3-catalog",
         "identity-v3-tokens-validate",
         "networks-l3-router",
@@ -293,6 +294,28 @@
         }
       }
     },
+    "compute-keypairs-create-type": {
+      "achievements": [
+        "deployed",
+        "clients",
+        "future",
+        "stable",
+        "complete",
+        "discover",
+        "doc",
+        "atomic",
+        "proximity"
+      ],
+      "admin": false,
+      "description": "Generate, import, and delete SSH or x509 keys within Compute services",
+      "project": "nova",
+      "required-since": "",
+      "tests": {
+        "tempest.api.compute.keypairs.test_keypairs_v22.KeyPairsV22TestJSON.test_keypairsv22_create_list_show_with_type": {
+          "idempotent_id": "id-89d59d43-f735-441a-abcf-0601727f47b6"
+        }
+      }
+    },
     "compute-quotas-get": {
       "achievements": [
         "foundation",
diff --git a/working_materials/scoring.txt b/working_materials/scoring.txt
index 52dd221b..11bfeca4 100644
--- a/working_materials/scoring.txt
+++ b/working_materials/scoring.txt
@@ -135,6 +135,7 @@ compute-images-create:           [0,1,1] [0,1,1] [1,1,1] [0,1,1] [1] [72]
 compute-instance-actions-get:    [1,1,1] [1,1,1] [1,0,0] [1,1,0] [1] [75]*
 compute-instance-actions-list:   [1,1,1] [1,1,1] [1,0,0] [1,1,0] [1] [75]*
 compute-keypairs-create:         [1,1,1] [1,1,1] [1,1,1] [0,1,0] [1] [83]*
+compute-keypairs-create-type:    [1,0,1] [1,1,1] [1,1,0] [0,1,1] [1] [76]*
 compute-list-api-versions:       [1,0,0] [1,1,1] [1,0,1] [1,1,1] [1] [76]*
 compute-quotas-get:              [1,1,1] [1,1,1] [1,1,1] [1,1,1] [1] [100]*
 compute-servers-create:          [1,1,1] [1,1,1] [1,1,1] [1,1,1] [1] [100]*
diff --git a/working_materials/tabulated_scores.csv b/working_materials/tabulated_scores.csv
index 65ea91b2..0a32af42 100644
--- a/working_materials/tabulated_scores.csv
+++ b/working_materials/tabulated_scores.csv
@@ -33,6 +33,7 @@ compute-images-create,0,1,1,0,1,1,1,1,1,0,1,1,1,72
 compute-instance-actions-get,1,1,1,1,1,1,1,0,0,1,1,0,1,75*
 compute-instance-actions-list,1,1,1,1,1,1,1,0,0,1,1,0,1,75*
 compute-keypairs-create,1,1,1,1,1,1,1,1,1,0,1,0,1,83*
+compute-keypairs-create-type,1,0,1,1,1,1,1,1,0,0,1,1,1,76*
 compute-list-api-versions,1,0,0,1,1,1,1,0,1,1,1,1,1,76*
 compute-quotas-get,1,1,1,1,1,1,1,1,1,1,1,1,1,100*
 compute-servers-create,1,1,1,1,1,1,1,1,1,1,1,1,1,100*