From 7ed37dc9fdc9868d6f2fcd76be4c77fccfab135d Mon Sep 17 00:00:00 2001 From: Martin Kopec Date: Sun, 7 Mar 2021 11:57:16 +0000 Subject: [PATCH] Rename shared-file-system add-on to shared_file_system Having named the file differntly than the component name defined within was causing unnecessary troubles in the refstack server which parses it. Having the names consistent is a better practice than implementing various ifs in the server's backend and fronted and may definitely lead to less issues in the future. Change-Id: Ie491daa752320377d7fb3d3198c329955f65d569 --- ...-system.2020.11.json => shared_file_system.2020.11.json} | 6 +++--- ...d-file-system.next.json => shared_file_system.next.json} | 4 ++-- tox.ini | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) rename add-ons/{shared-file-system.2020.11.json => shared_file_system.2020.11.json} (98%) rename add-ons/{shared-file-system.next.json => shared_file_system.next.json} (99%) diff --git a/add-ons/shared-file-system.2020.11.json b/add-ons/shared_file_system.2020.11.json similarity index 98% rename from add-ons/shared-file-system.2020.11.json rename to add-ons/shared_file_system.2020.11.json index fce64e88..ab5bf47f 100644 --- a/add-ons/shared-file-system.2020.11.json +++ b/add-ons/shared_file_system.2020.11.json @@ -1,9 +1,9 @@ { "metadata": { - "id": "shared-file-system.2020.11", + "id": "shared_file_system.2020.11", "schema": "2.0", "reference": "https://opendev.org/osf/interop/raw/branch/master/doc/source/schema/2.0.json", - "source": "http://opendev.org/osf/interop/raw/branch/master/add-ons/shared-file-system.2020.11.json", + "source": "http://opendev.org/osf/interop/raw/branch/master/add-ons/shared_file_system.2020.11.json", "scoring": { "cutoff_score": 60, "criteria": { @@ -55,7 +55,7 @@ } }, "os_trademark_approval": { - "target_approval": "shared-file-system.2020.11.json", + "target_approval": "shared_file_system.2020.11.json", "releases": ["train", "ussuri", "victoria", "wallaby"], "status": "approved" } diff --git a/add-ons/shared-file-system.next.json b/add-ons/shared_file_system.next.json similarity index 99% rename from add-ons/shared-file-system.next.json rename to add-ons/shared_file_system.next.json index 67447149..5e12b86b 100644 --- a/add-ons/shared-file-system.next.json +++ b/add-ons/shared_file_system.next.json @@ -1,9 +1,9 @@ { "metadata": { - "id": "shared-file-system.next", + "id": "shared_file_system.next", "schema": "2.0", "reference": "https://opendev.org/osf/interop/raw/branch/master/doc/source/schema/2.0.json", - "source": "http://opendev.org/osf/interop/raw/branch/master/add-ons/shared-file-system.next.json", + "source": "http://opendev.org/osf/interop/raw/branch/master/add-ons/shared_file_system.next.json", "scoring": { "cutoff_score": 60, "criteria": { diff --git a/tox.ini b/tox.ini index 86686867..4f6f1964 100644 --- a/tox.ini +++ b/tox.ini @@ -72,7 +72,7 @@ commands= jsonlint -s add-ons/orchestration.2019.11.json jsonlint -s add-ons/orchestration.2020.06.json jsonlint -s add-ons/orchestration.2020.11.json - jsonlint -s add-ons/shared-file-system.next.json + jsonlint -s add-ons/shared_file_system.next.json [testenv:jsonschema] commands= @@ -101,7 +101,7 @@ commands= jsonschema doc/source/schema/2.0.json -i add-ons/orchestration.2019.11.json jsonschema doc/source/schema/2.0.json -i add-ons/orchestration.2020.06.json jsonschema doc/source/schema/2.0.json -i add-ons/orchestration.2020.11.json - jsonschema doc/source/schema/2.0.json -i add-ons/shared-file-system.next.json + jsonschema doc/source/schema/2.0.json -i add-ons/shared_file_system.next.json [testenv:consistency] commands=