From 1398bc44ee9906b5feb3273096ba15b547fc0361 Mon Sep 17 00:00:00 2001
From: Thierry Carrez <thierry@openstack.org>
Date: Thu, 20 Dec 2018 13:19:09 +0100
Subject: [PATCH] Add YAML linting in check and gate

Introduce YAML linting for check and gate queues so that
we don't introduce incorrect YAML in proposed changes.

Includes a couple of nit fixes so that tests actually pass.

Change-Id: Ie07f11a24fb2ad853b49b69fe295bcae2c5764e6
---
 .gitignore                |  1 +
 .zuul.yaml                |  8 ++++++--
 deployment_tools.yaml     |  2 +-
 openstack_components.yaml |  9 +++++----
 tox.ini                   | 15 +++++++++++++++
 5 files changed, 28 insertions(+), 7 deletions(-)
 create mode 100644 .gitignore
 create mode 100644 tox.ini

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..172bf57
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+.tox
diff --git a/.zuul.yaml b/.zuul.yaml
index e7c200a..fed0fc7 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -1,3 +1,7 @@
 - project:
-    templates:
-      - noop-jobs
+    check:
+      jobs:
+        - openstack-tox-validate
+    gate:
+      jobs:
+        - openstack-tox-validate
diff --git a/deployment_tools.yaml b/deployment_tools.yaml
index a85027b..7b39a8f 100644
--- a/deployment_tools.yaml
+++ b/deployment_tools.yaml
@@ -78,7 +78,7 @@ tabs:
             docs-title: Docs
             docs-url: https://docs.openstack.org/openstack-chef/latest/
             download-title: Find OpenStack Charms in the Charm Store
-            download-url: https://jujucharms.com/openstack 
+            download-url: https://jujucharms.com/openstack
             desc: >
               Collection of Charms to deploy OpenStack using
               the Juju framework.
diff --git a/openstack_components.yaml b/openstack_components.yaml
index 2e13fa9..ff3df66 100644
--- a/openstack_components.yaml
+++ b/openstack_components.yaml
@@ -548,9 +548,10 @@ tabs:
                 expect to see from the project in the upcoming release.
               title: Horizon - Project Update
             support-teams:
-               i18n: https://governance.openstack.org/tc/reference/projects/i18n.html
-               documentation:
-                 https://governance.openstack.org/tc/reference/projects/documentation.html
+              i18n:
+                https://governance.openstack.org/tc/reference/projects/i18n.html
+              documentation:
+                https://governance.openstack.org/tc/reference/projects/documentation.html
 
   - name: Operations services
     map-bucket: openstack-operations
@@ -742,7 +743,7 @@ tabs:
             docs-url: https://docs.openstack.org/kuryr/latest/
             desc: >
               Bridge between containers frameworks networking models to
-              OpenStack networking abstraction 
+              OpenStack networking abstraction
             project-team: kuryr
             dependencies:
               - neutron
diff --git a/tox.ini b/tox.ini
new file mode 100644
index 0000000..00e38d6
--- /dev/null
+++ b/tox.ini
@@ -0,0 +1,15 @@
+[tox]
+envlist = validate
+minversion = 1.6
+skipsdist = True
+
+[testenv]
+install_command = pip install -U {opts} {packages}
+
+[testenv:validate]
+basepython = python3
+deps =
+    yamllint==1.4.1
+commands =
+    yamllint -f parsable \
+      deployment_tools.yaml openstack_components.yaml sdks.yaml