From 1473c7c4b81f8b1a8fd3b41efc85d15b2b5cc61b Mon Sep 17 00:00:00 2001 From: Luigi Toscano Date: Fri, 3 Aug 2018 19:19:08 +0200 Subject: [PATCH] Fix: make sure that keystone_v3_support is a boolean Otherwise the "if keystone_v3_support:" condition is always true (any non empty string makes the condition True). Thanks Trevor McCasland for the analysis. Story: 2003307 Task: 24260 Change-Id: Iab146ccf31a039c888cecb4ac7e820ec55de80a4 --- config_tempest/services/services.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/config_tempest/services/services.py b/config_tempest/services/services.py index c93b5d72..c2163688 100644 --- a/config_tempest/services/services.py +++ b/config_tempest/services/services.py @@ -264,7 +264,11 @@ class Services(object): def set_service_extensions(self): postfix = "-feature-enabled" - keystone_v3_support = self._conf.get('identity' + postfix, 'api_v3') + try: + keystone_v3_support = self._conf.getboolean('identity' + postfix, + 'api_v3') + except ValueError: + keystone_v3_support = False if keystone_v3_support: self.get_service('identity').set_identity_v3_extensions()