From 41a4565c9fd9daa2be9ea02870ee71acf63429f0 Mon Sep 17 00:00:00 2001
From: Paul Van Eck <pvaneck@us.ibm.com>
Date: Tue, 24 Jan 2017 11:58:46 -0800
Subject: [PATCH] Add a check for nonexistent capabilities

On the results report page, for schema versions 1.3 and
above, a check is added to check if a capability listed in
the components section is also in the capabilities object.
This will prevent the parsing from erroring out.

Change-Id: If6e1ab8d73e6cd6aacfa1e38847c9d838f6d9877
---
 .../results-report/resultsReportController.js       |  7 +++++++
 refstack-ui/tests/unit/ControllerSpec.js            | 13 +++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/refstack-ui/app/components/results-report/resultsReportController.js b/refstack-ui/app/components/results-report/resultsReportController.js
index 39ba12a3..68108853 100644
--- a/refstack-ui/app/components/results-report/resultsReportController.js
+++ b/refstack-ui/app/components/results-report/resultsReportController.js
@@ -348,6 +348,13 @@
                 'passedFlagged': [],
                 'notPassedFlagged': []
             };
+
+            // For cases where a capability listed in components is not
+            // in the capabilities object.
+            if (!(capId in ctrl.guidelineData.capabilities)) {
+                return cap;
+            }
+
             // Loop through each test belonging to the capability.
             angular.forEach(ctrl.guidelineData.capabilities[capId].tests,
                 function (details, testId) {
diff --git a/refstack-ui/tests/unit/ControllerSpec.js b/refstack-ui/tests/unit/ControllerSpec.js
index 76c7657a..044f2ca9 100644
--- a/refstack-ui/tests/unit/ControllerSpec.js
+++ b/refstack-ui/tests/unit/ControllerSpec.js
@@ -554,6 +554,19 @@ describe('Refstack controllers', function () {
                 expect(ctrl.caps).toEqual(expectedCapsObject);
                 expect(ctrl.requiredPassPercent).toEqual(75);
                 expect(ctrl.nonFlagPassCount).toEqual(2);
+
+                // Test case where a component capability isn't listed in
+                // the capabilities object.
+                ctrl.guidelineData.components.compute.removed = ['fake_cap'];
+                ctrl.buildCapabilitiesObject();
+                expectedCapsObject.removed.caps = [{
+                    'id': 'fake_cap',
+                    'passedTests': [],
+                    'notPassedTests': [],
+                    'passedFlagged': [],
+                    'notPassedFlagged': []
+                }];
+                expect(ctrl.caps).toEqual(expectedCapsObject);
             });
 
         it('should have a method to determine if a test is flagged',