From 7f65a2c10406784fed7831c58f611cef29a95fcc Mon Sep 17 00:00:00 2001 From: "Swapnil Kulkarni (coolsvap)" Date: Mon, 4 Jan 2016 19:37:38 +0530 Subject: [PATCH] Replace assertEqual(None, *) with assertIsNone in tests Replace assertEqual(None, *) with assertIsNone in tests to have more clear messages in case of failure. Change-Id: I8faff65a87adde43373dc2c7874302cfb4d77e1f Partial-bug:#1280522 --- refstack/tests/unit/test_api_utils.py | 2 +- refstack/tests/unit/test_db.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/refstack/tests/unit/test_api_utils.py b/refstack/tests/unit/test_api_utils.py index 5d249977..1e91b337 100644 --- a/refstack/tests/unit/test_api_utils.py +++ b/refstack/tests/unit/test_api_utils.py @@ -390,7 +390,7 @@ class APIUtilsTestCase(base.BaseTestCase): ('fake_test', const.USER): 'some_other_user', ('fake_test', const.SHARED_TEST_RUN): None, }.get(args) - self.assertEqual(None, api_utils.get_user_role('fake_test')) + self.assertIsNone(api_utils.get_user_role('fake_test')) self.assertRaises(exc.HTTPError, api_utils.enforce_permissions, 'fake_test', const.ROLE_USER) self.assertRaises(exc.HTTPError, api_utils.enforce_permissions, diff --git a/refstack/tests/unit/test_db.py b/refstack/tests/unit/test_db.py index 552de813..e8f70a1a 100644 --- a/refstack/tests/unit/test_db.py +++ b/refstack/tests/unit/test_db.py @@ -532,7 +532,7 @@ class DBBackendTestCase(base.BaseTestCase): # Test no key match. filtered.all.return_value = [] result = api.get_pubkey(key) - self.assertEqual(None, result) + self.assertIsNone(result) session.query.assert_called_once_with(mock_model) query.filter_by.assert_called_once_with(md5_hash=khash)