openinfra/refstack
Code Issues Proposed changes

Replace assertEqual(True/False, *) -> assertTrue/False(*)

Browse Source 
Inspired by Dave Chen's change request on keystone about this, I
decided to check in refstack code to see if there were many cases.

Since unittest provides assertTrue and assertFalse, it is better
to use assertTrue(var) instead of assertEqual(True, var) and the same
thing applies to assertFalse.

Change-Id: I3fce4de35160c2d58f83d26403fa251d4437c2a3
Closes-Bug: #1531125
This commit is contained in:
SaiKiran 2016-01-05 16:35:33 +05:30
parent 4f6f92d0dc
commit 9fa24b6f7e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
refstack/tests/unit/test_api_utils.py
View File

@ -320,11 +320,11 @@ class APIUtilsTestCase(base.BaseTestCase):
mock_get_user_session.return_value = mock_session
mock_get_user = mock_db.user_get
mock_get_user.return_value = 'Dobby'
self.assertEqual(True, api_utils.is_authenticated())
self.assertTrue(api_utils.is_authenticated())
mock_db.user_get.called_once_with(mock_session)
mock_db.NotFound = db.NotFound
mock_get_user.side_effect = mock_db.NotFound('User')
self.assertEqual(False, api_utils.is_authenticated())
self.assertFalse(api_utils.is_authenticated())
@mock.patch('pecan.abort', side_effect=exc.HTTPError)
@mock.patch('refstack.db.get_test_meta_key')
@ -458,7 +458,7 @@ class APIUtilsTestCase(base.BaseTestCase):
const.OPENID_NS_SREG_EMAIL: 'foo@bar.org',
const.OPENID_NS_SREG_FULLNAME: 'foo'
}
self.assertEqual(True, api_utils.verify_openid_request(mock_request))
self.assertTrue(api_utils.verify_openid_request(mock_request))
mock_response.content = ('is_valid:false\n'
'ns:http://specs.openid.net/auth/2.0\n')