d18f8ad221
There were three main issues in the code from refstack repository that
were preventing refstack jobs from working:
1) Improper handling of sessions in the database API.
2) PEP8 job was failing because of outdated version of flake8.
3) The new version of cryptography library doesn't support signer() and
verifier() functions.
Issue #1 was solved by using the get_session() function as a context
manager instead of using session.begin() as a context manager. Using
session.begin() as a context manager does not ensure that the session
will be closed at the end of the context (see "Opening and Closing
a Session" and "Framing out a begin / commit / rollback block"
here [1]).
Issue #2 was solved by updating the libraries in
test-requirements.txt file. This change also forces flake8 to ignore
some pep8 errors (similar to the ones ignored in tempest project).
Issue #3 was solved by using the sign() and verify() functions instead
of verifier() and signer() functions [2].
Related Taiga issues:
- https://tree.taiga.io/project/openstack-interop-working-group/issue/77
- https://tree.taiga.io/project/openstack-interop-working-group/issue/79
[1] https://docs.sqlalchemy.org/en/14/orm/session_basics.html
[2] e71c0df301
Change-Id: If98670475b371d1ece7c877a0eea3158f6c1b3f5
97 lines
3.3 KiB
INI
97 lines
3.3 KiB
INI
[tox]
|
|
envlist = py3,pep8,pip-check-reqs
|
|
minversion = 3.18
|
|
skipsdist = True
|
|
|
|
[testenv]
|
|
usedevelop = True
|
|
install_command = pip install -c{env:UPPER_CONSTRAINTS_FILE:https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt} -U {opts} {packages}
|
|
setenv =
|
|
VIRTUAL_ENV={envdir}
|
|
LANG=en_US.UTF-8
|
|
LANGUAGE=en_US:en
|
|
LC_ALL=C
|
|
allowlist_externals =
|
|
find
|
|
{toxinidir}/setup-mysql-tests.sh
|
|
{toxinidir}/tools/cover.sh
|
|
deps = -r{toxinidir}/requirements.txt
|
|
-r{toxinidir}/test-requirements.txt
|
|
commands =
|
|
find . -type f -name "*.pyc" -delete
|
|
stestr run {posargs}
|
|
distribute = false
|
|
|
|
[testenv:functional]
|
|
basepython = python3
|
|
setenv = SUBUNIT_TEST_PATH=./refstack/tests/api
|
|
# Integration/functional tests
|
|
# must not be run in parallel (--concurrency=1),
|
|
# because each of these tests
|
|
# require cleanup of database
|
|
commands = {toxinidir}/setup-mysql-tests.sh stestr run --test-path ./refstack/tests/api {posargs:--concurrency=1}
|
|
|
|
[testenv:pep8]
|
|
commands =
|
|
flake8 {posargs}
|
|
flake8 --filename=refstack* bin
|
|
distribute = false
|
|
|
|
[testenv:genconfig]
|
|
commands =
|
|
oslo-config-generator --output-file etc/refstack.conf.sample \
|
|
--namespace refstack \
|
|
--namespace oslo.db \
|
|
--namespace oslo.log
|
|
|
|
[testenv:venv]
|
|
commands = {posargs}
|
|
|
|
[testenv:cover]
|
|
commands = {toxinidir}/tools/cover.sh {posargs}
|
|
|
|
[testenv:docs]
|
|
deps = -c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
|
|
-r{toxinidir}/doc/requirements.txt
|
|
commands = sphinx-build -b html doc/source doc/build/html
|
|
|
|
[flake8]
|
|
# E125 is a won't fix until https://github.com/jcrocholl/pep8/issues/126 is resolved. For further detail see https://review.opendev.org/#/c/36788/
|
|
# E123 skipped because it is ignored by default in the default pep8
|
|
# E129 skipped because it is too limiting when combined with other rules
|
|
# W504 skipped because it is overeager and unnecessary
|
|
# H404 multi line docstring should start with a summary
|
|
# H405 skipped because it arbitrarily forces doctring "title" lines
|
|
ignore = E125,E123,E129,W504,H404,H405
|
|
show-source = True
|
|
exclude = .git,.venv,.tox,dist,doc,*egg,build,*lib/python*,*alembic/versions*
|
|
enable-extensions = H106,H203,H904
|
|
import-order-style = pep8
|
|
builtins = _
|
|
|
|
[testenv:pip-check-reqs]
|
|
# Do not install test-requirements as that will pollute the virtualenv for
|
|
# determining missing packages.
|
|
# This also means that pip-check-reqs must be installed separately, outside
|
|
# of the requirements.txt files
|
|
deps = pip_check_reqs
|
|
-r{toxinidir}/requirements.txt
|
|
commands=
|
|
# PyMySQL is a python only runtime dep if using MySQL
|
|
pip-extra-reqs -d --ignore-file=refstack/tests/* --ignore-requirement=PyMySQL refstack tools
|
|
pip-missing-reqs -d --ignore-file=refstack/tests/* refstack tools
|
|
|
|
[testenv:debug]
|
|
commands = oslo_debug_helper -t refstack/tests/unit {posargs}
|
|
|
|
[testenv:bindep]
|
|
# Do not install any requirements. We want this to be fast and work even if
|
|
# system dependencies are missing, since it's used to tell you what system
|
|
# dependencies are missing! This also means that bindep must be installed
|
|
# separately, outside of the requirements files, and develop mode disabled
|
|
# explicitly to avoid unnecessarily installing the checked-out repo too (this
|
|
# further relies on "tox.skipsdist = True" above).
|
|
deps = bindep
|
|
commands = bindep test
|
|
usedevelop = False
|