openstack/ansible-role-systemd_mount
Code Issues Proposed changes

Fix linters and metadata

Browse Source 
With update of ansible-lint to version >=6.0.0 a lot of new
linters were added, that enabled by default. In order to comply
with linter rules we're applying changes to the role.

With that we also update metdata to reflect current state.

Change-Id: I8bd832c172ef87acca27f053c5223941d80f9ce1
This commit is contained in:
Dmitriy Rabotyagov 2023-07-12 12:29:45 +02:00
parent 34b6061ab5
commit 3448df38f5
4 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
defaults/main.yml
View File

@ -15,7 +15,8 @@
# EPEL repo is required for s3fs package. It won't be added in case s3fs is not required. # EPEL repo is required for s3fs package. It won't be added in case s3fs is not required.
systemd_centos_epel_mirror: "{{ centos_epel_mirror | default('http://download.fedoraproject.org/pub/epel') }}" systemd_centos_epel_mirror: "{{ centos_epel_mirror | default('http://download.fedoraproject.org/pub/epel') }}"
systemd_centos_epel_key: "{{ centos_epel_key | default('http://download.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-' ~ ansible_facts['distribution_major_version']) }}" systemd_centos_epel_key: >-
{{ centos_epel_key | default('http://download.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-' ~ ansible_facts['distribution_major_version']) }}
# Any optioned required to make the mount point work. If no options are # Any optioned required to make the mount point work. If no options are
# provided the default will be used. This list is comma separted. # provided the default will be used. This list is comma separted.

12
meta/main.yml
View File

@ -18,18 +18,20 @@ galaxy_info:
description: Installation and setup of systemd_mount description: Installation and setup of systemd_mount
company: Rackspace company: Rackspace
license: Apache2 license: Apache2
min_ansible_version: 2.0 role_name: systemd_mount
namespace: openstack
min_ansible_version: "2.10"
platforms: platforms:
- name: Debian - name: Debian
versions: versions:
- buster - bullseye
- name: Ubuntu - name: Ubuntu
versions: versions:
- bionic
- focal - focal
- jammy
- name: EL - name: EL
versions: versions:
- 8 - "9"
categories: galaxy_tags:
- systemd - systemd
- development - development

6
tasks/main.yml
View File

@ -28,7 +28,9 @@
tags: tags:
- always - always
- include_tasks: systemd_install.yml - name: Including systemd_install tasks
include_tasks: systemd_install.yml
- include_tasks: systemd_mounts.yml - name: Including systemd_mounts tasks
include_tasks: systemd_mounts.yml
with_items: "{{ systemd_mounts }}" with_items: "{{ systemd_mounts }}"

4
tasks/systemd_install.yml
View File

@ -22,6 +22,7 @@
get_url: get_url:
url: "{{ systemd_centos_epel_key }}" url: "{{ systemd_centos_epel_key }}"
dest: /etc/pki/rpm-gpg dest: /etc/pki/rpm-gpg
mode: "0640"
register: _get_yum_keys register: _get_yum_keys
until: _get_yum_keys is success until: _get_yum_keys is success
retries: 5 retries: 5
@ -66,6 +67,7 @@
copy: copy:
content: "c /dev/fuse 0600 - - - 10:229" content: "c /dev/fuse 0600 - - - 10:229"
dest: "/etc/tmpfiles.d/openstack-ansible-systemd_mount-glusterfs-client.conf" dest: "/etc/tmpfiles.d/openstack-ansible-systemd_mount-glusterfs-client.conf"
mode: "0644"
register: _glusterfs_server_tmpfiles register: _glusterfs_server_tmpfiles
- name: Apply systemctl overrides - name: Apply systemctl overrides
@ -87,4 +89,4 @@
name: "systemd-tmpfiles-setup-dev" name: "systemd-tmpfiles-setup-dev"
state: restarted state: restarted
when: when:
- _glusterfs_server_tmpfiles is changed - _glusterfs_server_tmpfiles is changed