ansible-role-tripleo-sahara/ci-scripts/ansible-lint.sh
Jill Rouleau 003e81f3c0 Add required role repo contents
- Add tox configuration
- Add requirements and test-requirements.txt
- Add setup files
- Add ci-scripts for ansible-lint
- Add cookiecutter directories and yml files

Change-Id: I535d357f4b02149801db50c937f44123b70c35ed
2018-09-06 12:45:46 -07:00

22 lines
877 B
Bash

#!/bin/bash
# ANSIBLE0006: Using command rather than module
# we have a few use cases where we need to use curl and rsync
# ANSIBLE0007: Using command rather than an argument to e.g file
# we have a lot of 'rm' command and we should use file module instead
# ANSIBLE0010: Package installs should not use latest.
# Sometimes we need to update some packages.
# ANSIBLE0012: Commands should not change things if nothing needs doing
# ANSIBLE0013: Use Shell only when shell functionality is required
# ANSIBLE0016: Tasks that run when changed should likely be handlers
# this requires refactoring roles, skipping for now
SKIPLIST="ANSIBLE0006,ANSIBLE0007,ANSIBLE0010,ANSIBLE0012,ANSIBLE0013,ANSIBLE0016"
# Lin the role.
ansible-lint -vvv -x $SKIPLIST ./ || lint_error=1
# exit with 1 if we had a least an error or warning.
if [[ -n "$lint_error" ]]; then
exit 1;
fi