From de8087f382225732849e6daa0a7b92ed26f57764 Mon Sep 17 00:00:00 2001 From: Mehdi Abaakouk Date: Mon, 31 Jul 2017 17:01:01 +0200 Subject: [PATCH] gnocchi: set start/stop when validating alarm Now, it's required to set start and stop when we do cross aggregation with needed_overlap. So sets it. Change-Id: I2675daacd1c5f0e80025d7ed689bdbda5dd9e6ce --- aodh/api/controllers/v2/alarm_rules/gnocchi.py | 2 ++ aodh/tests/functional/api/v2/test_alarm_scenarios.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/aodh/api/controllers/v2/alarm_rules/gnocchi.py b/aodh/api/controllers/v2/alarm_rules/gnocchi.py index 25663d2a0..388850344 100644 --- a/aodh/api/controllers/v2/alarm_rules/gnocchi.py +++ b/aodh/api/controllers/v2/alarm_rules/gnocchi.py @@ -191,6 +191,8 @@ class AggregationMetricByResourcesLookupRule(AlarmGnocchiThresholdRule): query=query, aggregation=rule.aggregation_method, needed_overlap=0, + start="-1 day", + stop="now", resource_type=rule.resource_type) except exceptions.ClientException as e: if e.code == 404: diff --git a/aodh/tests/functional/api/v2/test_alarm_scenarios.py b/aodh/tests/functional/api/v2/test_alarm_scenarios.py index 5699fb9ce..ded010eac 100644 --- a/aodh/tests/functional/api/v2/test_alarm_scenarios.py +++ b/aodh/tests/functional/api/v2/test_alarm_scenarios.py @@ -2721,6 +2721,8 @@ class TestAlarmsRuleGnocchi(TestAlarmsBase): aggregation='count', metrics='ameter', needed_overlap=0, + start="-1 day", + stop="now", query=expected_query, resource_type="instance")], c.metric.aggregation.mock_calls),