openstack/aodh
Code Issues Proposed changes

Make LBaaS total_connections cumulative

Browse Source 
The total_connections LBaaS data point is presently incorrectly
listed as a gauge. Since the total_connections data point will be an
ever-increasing value (much the same as bytes_in and bytes_out are),
this commit corrects total_connections to also be cumulative.

Change-Id: I60d468a7d24e0a5bdb4c2f680af24397b4c0d77c
Closes-Bug: #1401352
This commit is contained in:
Stephen Balukoff 2014-12-10 18:02:14 -08:00
parent 9af8f521e3
commit 09d21e8e51
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ceilometer/network/services/lbaas.py
View File

@ -281,7 +281,7 @@ class LBTotalConnectionsPollster(_LBStatsPollster):
return make_sample_from_pool(
pool,
name='network.services.lb.total.connections',
type=sample.TYPE_GAUGE,
type=sample.TYPE_CUMULATIVE,
unit='connection',
volume=data.total_connections,
)

2
ceilometer/tests/network/services/test_lbaas.py
View File

@ -486,7 +486,7 @@ class TestLBStatsPollster(_BaseTestLBPollster):
def test_lb_total_connections(self):
self._check_get_samples(lbaas.LBTotalConnectionsPollster,
'network.services.lb.total.connections',
4L, 'gauge')
4L, 'cumulative')
def test_lb_active_connections(self):
self._check_get_samples(lbaas.LBActiveConnectionsPollster,

2
doc/source/measurements.rst
View File

@ -341,7 +341,7 @@ network.services.lb.pool Gauge pool pool ID p
network.services.lb.vip Gauge vip vip ID pollster Existence of a LB Vip
network.services.lb.member Gauge member member ID pollster Existence of a LB Member
network.services.lb.health_monitor Gauge monitor monitor ID pollster Existence of a LB Health Probe
network.services.lb.total.connections Gauge connection pool ID pollster Total connections on a LB
network.services.lb.total.connections Cumulative connection pool ID pollster Total connections on a LB
network.services.lb.active.connections Gauge connection pool ID pollster Active connections on a LB
network.services.lb.incoming.bytes Cumulative B pool ID pollster Number of incoming Bytes
network.services.lb.outgoing.bytes Cumulative B pool ID pollster Number of outgoing Bytes