improve performance of resource-list in sql
simplify the query to retrieve list of resources. it is much simpler to query against raw Sample data then to join against Resource table. also, add meter_links param to allow ability to disable link generation of relate meters. Change-Id: Ia4ceafc568c4a2e4c8e6b7586511135627b9335e Closes-Bug: #1264434 Implements: blueprint big-data-sql
This commit is contained in:
Gordon Chung
Gerrit Code Review
parent
e8a7eed15c
commit
13e2ebcfb0
@ -1425,14 +1425,15 @@ class Resource(_Base):
|
||||
class ResourcesController(rest.RestController):
|
||||
"""Works on resources."""
|
||||
|
||||
def _resource_links(self, resource_id):
|
||||
def _resource_links(self, resource_id, meter_links=1):
|
||||
links = [_make_link('self', pecan.request.host_url, 'resources',
|
||||
resource_id)]
|
||||
for meter in pecan.request.storage_conn.get_meters(resource=
|
||||
resource_id):
|
||||
query = {'field': 'resource_id', 'value': resource_id}
|
||||
links.append(_make_link(meter.name, pecan.request.host_url,
|
||||
'meters', meter.name, query=query))
|
||||
if meter_links:
|
||||
for meter in pecan.request.storage_conn.get_meters(resource=
|
||||
resource_id):
|
||||
query = {'field': 'resource_id', 'value': resource_id}
|
||||
links.append(_make_link(meter.name, pecan.request.host_url,
|
||||
'meters', meter.name, query=query))
|
||||
return links
|
||||
|
||||
@wsme_pecan.wsexpose(Resource, unicode)
|
||||
@ -1449,16 +1450,18 @@ class ResourcesController(rest.RestController):
|
||||
return Resource.from_db_and_links(resources[0],
|
||||
self._resource_links(resource_id))
|
||||
|
||||
@wsme_pecan.wsexpose([Resource], [Query])
|
||||
def get_all(self, q=[]):
|
||||
@wsme_pecan.wsexpose([Resource], [Query], int)
|
||||
def get_all(self, q=[], meter_links=1):
|
||||
"""Retrieve definitions of all of the resources.
|
||||
|
||||
:param q: Filter rules for the resources to be returned.
|
||||
:param meter_links: option to include related meter links
|
||||
"""
|
||||
kwargs = _query_to_kwargs(q, pecan.request.storage_conn.get_resources)
|
||||
resources = [
|
||||
Resource.from_db_and_links(r,
|
||||
self._resource_links(r.resource_id))
|
||||
self._resource_links(r.resource_id,
|
||||
meter_links))
|
||||
for r in pecan.request.storage_conn.get_resources(**kwargs)]
|
||||
return resources
|
||||
|
||||
|
||||
@ -444,90 +444,67 @@ class Connection(base.Connection):
|
||||
:param resource: Optional resource filter.
|
||||
:param pagination: Optional pagination query.
|
||||
"""
|
||||
|
||||
# We probably want to raise these early, since we don't know from here
|
||||
# if they will be handled. We don't want extra wait or work for it to
|
||||
# just fail.
|
||||
if pagination:
|
||||
raise NotImplementedError('Pagination not implemented')
|
||||
|
||||
def _apply_filters(query):
|
||||
#TODO(gordc) this should be merged with make_query_from_filter
|
||||
for column, value in [(models.Sample.resource_id, resource),
|
||||
(models.Sample.user_id, user),
|
||||
(models.Sample.project_id, project)]:
|
||||
if value:
|
||||
query = query.filter(column == value)
|
||||
if source:
|
||||
query = query.filter(
|
||||
models.Sample.sources.any(id=source))
|
||||
if metaquery:
|
||||
query = apply_metaquery_filter(session, query, metaquery)
|
||||
if start_timestamp:
|
||||
if start_timestamp_op == 'gt':
|
||||
query = query.filter(
|
||||
models.Sample.timestamp > start_timestamp)
|
||||
else:
|
||||
query = query.filter(
|
||||
models.Sample.timestamp >= start_timestamp)
|
||||
if end_timestamp:
|
||||
if end_timestamp_op == 'le':
|
||||
query = query.filter(
|
||||
models.Sample.timestamp <= end_timestamp)
|
||||
else:
|
||||
query = query.filter(
|
||||
models.Sample.timestamp < end_timestamp)
|
||||
return query
|
||||
|
||||
session = self._get_db_session()
|
||||
# get list of resource_ids
|
||||
res_q = session.query(distinct(models.Sample.resource_id))
|
||||
res_q = _apply_filters(res_q)
|
||||
|
||||
# (thomasm) We need to get the max timestamp first, since that's the
|
||||
# most accurate. We also need to filter down in the subquery to
|
||||
# constrain what we have to JOIN on later.
|
||||
ts_subquery = session.query(
|
||||
models.Sample.resource_id,
|
||||
func.max(models.Sample.timestamp).label("max_ts"),
|
||||
func.min(models.Sample.timestamp).label("min_ts")
|
||||
).group_by(models.Sample.resource_id)
|
||||
for res_id in res_q.all():
|
||||
# get latest Sample
|
||||
max_q = session.query(models.Sample)\
|
||||
.filter(models.Sample.resource_id == res_id[0])
|
||||
max_q = _apply_filters(max_q)
|
||||
max_q = max_q.order_by(models.Sample.timestamp.desc(),
|
||||
models.Sample.id.desc()).limit(1)
|
||||
|
||||
# Here are the basic 'eq' operation filters for the sample data.
|
||||
for column, value in [(models.Sample.resource_id, resource),
|
||||
(models.Sample.user_id, user),
|
||||
(models.Sample.project_id, project)]:
|
||||
if value:
|
||||
ts_subquery = ts_subquery.filter(column == value)
|
||||
# get the min timestamp value.
|
||||
min_q = session.query(models.Sample.timestamp)\
|
||||
.filter(models.Sample.resource_id == res_id[0])
|
||||
min_q = _apply_filters(min_q)
|
||||
min_q = min_q.order_by(models.Sample.timestamp.asc()).limit(1)
|
||||
|
||||
if source:
|
||||
ts_subquery = ts_subquery.filter(
|
||||
models.Sample.sources.any(id=source))
|
||||
|
||||
if metaquery:
|
||||
ts_subquery = apply_metaquery_filter(session,
|
||||
ts_subquery,
|
||||
metaquery)
|
||||
|
||||
# Here we limit the samples being used to a specific time period,
|
||||
# if requested.
|
||||
if start_timestamp:
|
||||
if start_timestamp_op == 'gt':
|
||||
ts_subquery = ts_subquery.filter(
|
||||
models.Sample.timestamp > start_timestamp)
|
||||
else:
|
||||
ts_subquery = ts_subquery.filter(
|
||||
models.Sample.timestamp >= start_timestamp)
|
||||
if end_timestamp:
|
||||
if end_timestamp_op == 'le':
|
||||
ts_subquery = ts_subquery.filter(
|
||||
models.Sample.timestamp <= end_timestamp)
|
||||
else:
|
||||
ts_subquery = ts_subquery.filter(
|
||||
models.Sample.timestamp < end_timestamp)
|
||||
ts_subquery = ts_subquery.subquery()
|
||||
|
||||
# Now we need to get the max Sample.id out of the leftover results, to
|
||||
# break any ties.
|
||||
agg_subquery = session.query(
|
||||
func.max(models.Sample.id).label("max_id"),
|
||||
ts_subquery
|
||||
).filter(
|
||||
models.Sample.resource_id == ts_subquery.c.resource_id,
|
||||
models.Sample.timestamp == ts_subquery.c.max_ts
|
||||
).group_by(
|
||||
ts_subquery.c.resource_id,
|
||||
ts_subquery.c.max_ts,
|
||||
ts_subquery.c.min_ts
|
||||
).subquery()
|
||||
|
||||
query = session.query(
|
||||
models.Sample,
|
||||
agg_subquery.c.min_ts,
|
||||
agg_subquery.c.max_ts
|
||||
).filter(
|
||||
models.Sample.id == agg_subquery.c.max_id
|
||||
)
|
||||
|
||||
for sample, first_ts, last_ts in query.all():
|
||||
yield api_models.Resource(
|
||||
resource_id=sample.resource_id,
|
||||
project_id=sample.project_id,
|
||||
first_sample_timestamp=first_ts,
|
||||
last_sample_timestamp=last_ts,
|
||||
source=sample.sources[0].id,
|
||||
user_id=sample.user_id,
|
||||
metadata=sample.resource_metadata
|
||||
)
|
||||
sample = max_q.first()
|
||||
if sample:
|
||||
yield api_models.Resource(
|
||||
resource_id=sample.resource_id,
|
||||
project_id=sample.project_id,
|
||||
first_sample_timestamp=min_q.first().timestamp,
|
||||
last_sample_timestamp=sample.timestamp,
|
||||
source=sample.sources[0].id,
|
||||
user_id=sample.user_id,
|
||||
metadata=sample.resource_metadata
|
||||
)
|
||||
|
||||
def get_meters(self, user=None, project=None, resource=None, source=None,
|
||||
metaquery={}, pagination=None):
|
||||
@ -544,66 +521,48 @@ class Connection(base.Connection):
|
||||
if pagination:
|
||||
raise NotImplementedError('Pagination not implemented')
|
||||
|
||||
def _apply_filters(query):
|
||||
#TODO(gordc) this should be merged with make_query_from_filter
|
||||
for column, value in [(models.Sample.resource_id, resource),
|
||||
(models.Sample.user_id, user),
|
||||
(models.Sample.project_id, project)]:
|
||||
if value:
|
||||
query = query.filter(column == value)
|
||||
if source is not None:
|
||||
query = query.filter(
|
||||
models.Sample.sources.any(id=source))
|
||||
if metaquery:
|
||||
query = apply_metaquery_filter(session, query, metaquery)
|
||||
return query
|
||||
|
||||
session = self._get_db_session()
|
||||
|
||||
# Sample table will store large records and join with resource
|
||||
# will be very slow.
|
||||
# subquery_sample is used to reduce sample records
|
||||
# by selecting a record for each (resource_id, counter_name).
|
||||
# sample_subq is used to reduce sample records
|
||||
# by selecting a record for each (resource_id, meter_id).
|
||||
# max() is used to choice a sample record, so the latest record
|
||||
# is selected for each (resource_id, meter.name).
|
||||
|
||||
subquery_sample = session.query(
|
||||
# is selected for each (resource_id, meter_id).
|
||||
sample_subq = session.query(
|
||||
func.max(models.Sample.id).label('id'))\
|
||||
.join(models.Meter)\
|
||||
.group_by(models.Sample.resource_id,
|
||||
models.Meter.name).subquery()
|
||||
.group_by(models.Sample.meter_id, models.Sample.resource_id)
|
||||
sample_subq = sample_subq.subquery()
|
||||
|
||||
# The SQL of query_sample is essentially:
|
||||
#
|
||||
# SELECT sample.* FROM sample INNER JOIN
|
||||
# (SELECT max(sample.id) AS id FROM sample
|
||||
# GROUP BY sample.resource_id, meter.name) AS anon_2
|
||||
# GROUP BY sample.resource_id, sample.meter_id) AS anon_2
|
||||
# ON sample.id = anon_2.id
|
||||
|
||||
query_sample = session.query(models.MeterSample).\
|
||||
join(subquery_sample,
|
||||
models.MeterSample.id == subquery_sample.c.id)
|
||||
join(sample_subq, models.MeterSample.id == sample_subq.c.id)
|
||||
query_sample = _apply_filters(query_sample)
|
||||
|
||||
if metaquery:
|
||||
query_sample = apply_metaquery_filter(session,
|
||||
query_sample,
|
||||
metaquery)
|
||||
|
||||
alias_sample = aliased(models.MeterSample,
|
||||
query_sample.with_labels().subquery())
|
||||
query = session.query(models.Resource, alias_sample)\
|
||||
.filter(models.Resource.id == alias_sample.resource_id)
|
||||
|
||||
if user is not None:
|
||||
query = query.filter(models.Resource.user_id == user)
|
||||
if source is not None:
|
||||
query = query.filter(models.Resource.sources.any(id=source))
|
||||
if resource:
|
||||
query = query.filter(models.Resource.id == resource)
|
||||
if project is not None:
|
||||
query = query.filter(models.Resource.project_id == project)
|
||||
|
||||
for resource, sample in query.all():
|
||||
for sample in query_sample.all():
|
||||
yield api_models.Meter(
|
||||
name=sample.counter_name,
|
||||
type=sample.counter_type,
|
||||
unit=sample.counter_unit,
|
||||
resource_id=resource.id,
|
||||
project_id=resource.project_id,
|
||||
source=resource.sources[0].id,
|
||||
user_id=resource.user_id)
|
||||
|
||||
def _apply_options(self, query, orderby, limit, table):
|
||||
query = self._apply_order_by(query, orderby, table)
|
||||
if limit is not None:
|
||||
query = query.limit(limit)
|
||||
return query
|
||||
resource_id=sample.resource_id,
|
||||
project_id=sample.project_id,
|
||||
source=sample.sources[0].id,
|
||||
user_id=sample.user_id)
|
||||
|
||||
def _retrieve_samples(self, query):
|
||||
samples = query.all()
|
||||
|
||||
@ -515,3 +515,31 @@ class TestListResources(FunctionalTest,
|
||||
self.assertTrue((self.PATH_PREFIX + '/meters/instance?'
|
||||
'q.field=resource_id&q.value=resource-id')
|
||||
in links[1]['href'])
|
||||
|
||||
def test_resource_skip_meter_links(self):
|
||||
sample1 = sample.Sample(
|
||||
'instance',
|
||||
'cumulative',
|
||||
'',
|
||||
1,
|
||||
'user-id',
|
||||
'project-id',
|
||||
'resource-id',
|
||||
timestamp=datetime.datetime(2012, 7, 2, 10, 40),
|
||||
resource_metadata={'display_name': 'test-server',
|
||||
'tag': 'self.sample',
|
||||
},
|
||||
source='test_list_resources',
|
||||
)
|
||||
msg = utils.meter_message_from_counter(
|
||||
sample1,
|
||||
self.CONF.publisher.metering_secret,
|
||||
)
|
||||
self.conn.record_metering_data(msg)
|
||||
|
||||
data = self.get_json('/resources?meter_links=0')
|
||||
links = data[0]['links']
|
||||
self.assertEqual(len(links), 1)
|
||||
self.assertEqual(links[0]['rel'], 'self')
|
||||
self.assertTrue((self.PATH_PREFIX + '/resources/resource-id')
|
||||
in links[0]['href'])
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user