From e66c628b72e5a6769afb2eeabb5e65f7f1c2aca4 Mon Sep 17 00:00:00 2001
From: Ryota MIBU <r-mibu@cq.jp.nec.com>
Date: Tue, 8 Sep 2015 01:51:54 +0900
Subject: [PATCH] event-alarm: add unit tests for various trait types

Change-Id: I49775d7a56ac9eb9f79218cb6f3fbcab54085d79
---
 aodh/tests/evaluator/test_event.py | 90 +++++++++++++++++++++++++++++-
 1 file changed, 88 insertions(+), 2 deletions(-)

diff --git a/aodh/tests/evaluator/test_event.py b/aodh/tests/evaluator/test_event.py
index 6c8c68683..c0943cf0f 100644
--- a/aodh/tests/evaluator/test_event.py
+++ b/aodh/tests/evaluator/test_event.py
@@ -251,7 +251,7 @@ class TestEventAlarmEvaluate(base.TestEvaluatorBase):
             expect_alarm_updates=[],
             expect_notifications=[])
 
-    def test_fire_alarm_query_matched(self):
+    def test_fire_alarm_query_matched_string(self):
         alarm = self._alarm(query=[dict(field="traits.state",
                                         value="stopped",
                                         op="eq")])
@@ -262,7 +262,7 @@ class TestEventAlarmEvaluate(base.TestEvaluatorBase):
             expect_alarm_updates=[alarm],
             expect_notifications=[dict(alarm=alarm, event=event)])
 
-    def test_skip_query_unmatched(self):
+    def test_skip_query_unmatched_string(self):
         alarm = self._alarm(query=[dict(field="traits.state",
                                         value="stopped",
                                         op="eq")])
@@ -273,6 +273,92 @@ class TestEventAlarmEvaluate(base.TestEvaluatorBase):
             expect_alarm_updates=[],
             expect_notifications=[])
 
+    def test_fire_alarm_query_matched_integer(self):
+        alarm = self._alarm(query=[dict(field="traits.instance_type_id",
+                                        type="integer",
+                                        value="5",
+                                        op="eq")])
+        event = self._event(traits=[['instance_type_id', 2, 5]])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.ALARM},
+            expect_alarm_updates=[alarm],
+            expect_notifications=[dict(alarm=alarm, event=event)])
+
+    def test_skip_query_unmatched_integer(self):
+        alarm = self._alarm(query=[dict(field="traits.instance_type_id",
+                                        type="integer",
+                                        value="5",
+                                        op="eq")])
+        event = self._event(traits=[['instance_type_id', 2, 6]])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.UNKNOWN},
+            expect_alarm_updates=[],
+            expect_notifications=[])
+
+    def test_fire_alarm_query_matched_float(self):
+        alarm = self._alarm(query=[dict(field="traits.io_read_kbs",
+                                        type="float",
+                                        value="123.456",
+                                        op="eq")])
+        event = self._event(traits=[['io_read_kbs', 3, 123.456]])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.ALARM},
+            expect_alarm_updates=[alarm],
+            expect_notifications=[dict(alarm=alarm, event=event)])
+
+    def test_skip_query_unmatched_float(self):
+        alarm = self._alarm(query=[dict(field="traits.io_read_kbs",
+                                        type="float",
+                                        value="123.456",
+                                        op="eq")])
+        event = self._event(traits=[['io_read_kbs', 3, 456.123]])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.UNKNOWN},
+            expect_alarm_updates=[],
+            expect_notifications=[])
+
+    def test_fire_alarm_query_matched_datetime(self):
+        alarm = self._alarm(query=[dict(field="traits.created_at",
+                                        type="datetime",
+                                        value="2015-09-01T18:52:27.214309",
+                                        op="eq")])
+        event = self._event(traits=[['created_at', 4,
+                                     '2015-09-01T18:52:27.214309']])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.ALARM},
+            expect_alarm_updates=[alarm],
+            expect_notifications=[dict(alarm=alarm, event=event)])
+
+    def test_skip_query_unmatched_datetime(self):
+        alarm = self._alarm(query=[dict(field="traits.created_at",
+                                        type="datetime",
+                                        value="2015-09-01T18:52:27.214309",
+                                        op="eq")])
+        event = self._event(traits=[['created_at', 4,
+                                     '2015-09-02T18:52:27.214309']])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.UNKNOWN},
+            expect_alarm_updates=[],
+            expect_notifications=[])
+
+    def test_skip_alarm_due_to_uncompareable_trait(self):
+        alarm = self._alarm(query=[dict(field="traits.created_at",
+                                        type="datetime",
+                                        value="2015-09-01T18:52:27.214309",
+                                        op="eq")])
+        event = self._event(traits=[['created_at', 3, 123.456]])
+        self._do_test_event_alarm(
+            [alarm], [event],
+            expect_alarm_states={alarm.alarm_id: evaluator.UNKNOWN},
+            expect_alarm_updates=[],
+            expect_notifications=[])
+
     def test_event_alarm_cache_hit(self):
         alarm = self._alarm(project='project2', event_type='none')
         events = [