openstack/aodh
Code Issues Proposed changes

Remove conversion debug message

Browse Source 
Removing unnecessary debug message confusing the user to
think the error is fatal. Instead just let it pass silently
to avoid confusion. The debug message wasnt adding much
value anyway.

Closes-Bug: #1306280

Change-Id: I03420311f0a6ec77d68b750afce3c4110ccffecf
This commit is contained in:
Pradeep Kilambi 2014-04-22 09:25:22 -07:00
parent b6de8ddc0d
commit 3ef3572c70
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ceilometer/api/controllers/v2.py
View File

@ -242,9 +242,9 @@ class Query(_Base):
try:
converted_value = ast.literal_eval(self.value)
except (ValueError, SyntaxError):
msg = _('Failed to convert the metadata value %s'
' automatically') % (self.value)
LOG.debug(msg)
# Unable to convert the metadata value automatically
# let it default to self.value
pass
else:
if type not in self._supported_types:
# Types must be explicitly declared so the
@ -254,7 +254,7 @@ class Query(_Base):
raise TypeError()
converted_value = self._type_converters[type](self.value)
except ValueError:
msg = _('Failed to convert the value %(value)s'
msg = _('Unable to convert the value %(value)s'
' to the expected data type %(type)s.') % \
{'value': self.value, 'type': type}
raise ClientSideError(msg)