Deprecate a separate bifrost-inspector cloud

It is possible to provide both endpoints via one cloud record.

Change-Id: I6a3735a431e570b6d9bf5e6f3fba86fc980ef967

doc/source/user/howto.rst

@@ -17,13 +17,13 @@ example::
 
     export OS_CLOUD=bifrost
     baremetal node list
-
-In noauth mode, a cloud called ``bifrost-inspector`` is also included that
-allows access to the Ironic Inspector API. For example::
-
-    export OS_CLOUD=bifrost-inspector
     baremetal introspection list
 
+.. note::
+   Previously, a separate cloud ``bifrost-inspector`` was provided for
+   introspection commands. It is not deprecated, the main ``bifrost`` cloud
+   should always be used.
+
 Environment variables
 ---------------------
 

playbooks/roles/bifrost-keystone-client-config/templates/clouds.yaml.j2

@@ -17,7 +17,9 @@ clouds:
 {% else %}
   bifrost:
     auth_type: "none"
-    endpoint: {{ ironic_api_url }}
+    baremetal_endpoint_override: {{ ironic_api_url }}
+    baremetal_introspection_endpoint_override: {{ ironic_inspector_api_url }}
+  # Deprecated
   bifrost-inspector:
     auth_type: "none"
     endpoint: {{ ironic_inspector_api_url }}

playbooks/roles/bifrost-test-inspection/tasks/main.yml

@@ -16,7 +16,7 @@
   command: "baremetal introspection data save {{ uuid }}"
   register: inspection_data
   environment:
-    OS_CLOUD: "{% if enable_keystone | default(false) | bool %}bifrost{% else %}bifrost-inspector{% endif %}"
+    OS_CLOUD: bifrost
 
 # TODO(mgoddard): More validation of data format and contents.
 - name: Validate the inspection data format

playbooks/test-bifrost.yaml

@@ -115,7 +115,7 @@
     - name: "List introspection rules using openstack client"
       command: baremetal --debug introspection rule list
       environment:
-        OS_CLOUD: "{% if enable_keystone | default(false) | bool == true %}bifrost{% else %}bifrost-inspector{% endif %}"
+        OS_CLOUD: bifrost
         PATH: /usr/local/bin:{{ ansible_env.PATH }}
       when: enable_inspector is defined and enable_inspector | bool
 

releasenotes/notes/bifrost-inspector-a154561802d8d614.yaml

@@ -0,0 +1,9 @@
+---
+deprecations:
+  - |
+    The ``bifrost-inspector`` cloud in ``clouds.yaml`` is now deprecated, use
+    the main ``bifrost`` cloud for all commands.
+fixes:
+  - |
+    It is now possible to use the ``bifrost`` cloud with introspection commands
+    even in no-auth mode.