openstack/bifrost
Code Issues Proposed changes

Split inspection conditionals depending on auth mode

Browse Source 
There is a bug in the inspection module, which needs
to be corrected, although that is going to take potentially
a substantial amount of time given ansible's release cycle.

In the mean time, we're just going to have to work around it
until we're able to get the fix landed in ansible.

Change-Id: I70fc4b54c6cd815bdb755819ad28215714c71260
This commit is contained in:
Julia Kreger 2017-08-29 19:48:32 +00:00
parent 53c7656d65
commit 0e05496f6e
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
playbooks/roles/ironic-inspect-node/tasks/main.yml
View File

@ -61,7 +61,7 @@
become: yes
when: (inventory_dhcp | bool == true) or (inventory_dns | bool == true)
- name: "Execute node introspection"
- name: "Execute node introspection - noauth_mode"
os_ironic_inspect:
cloud: "{{ cloud_name | default(omit) }}"
auth_type: "{{ auth_type | default(omit) }}"
@ -70,3 +70,19 @@
uuid: "{{ uuid | default('') }}"
name: "{{ name | default('') }}"
timeout: "{{ inspection_wait_timeout }}"
when: noauth_mode is not defined or noauth_mode | bool == True
# NOTE(TheJulia): Some behavior appears to have changed in ansible at
# some point where arguments are passed that are part of the spec for,
# which raises a bug in the inspection module where auth_type must be
# defined, as it is otherwise always sent as a null value.
- name: "Execute node introspection"
os_ironic_inspect:
cloud: "{{ cloud_name | default(omit) }}"
auth_type: "{{ auth_type | default('password') }}"
auth: "{{ auth | default(omit) }}"
ironic_url: "{{ ironic_url | default(omit) }}"
uuid: "{{ uuid | default('') }}"
name: "{{ name | default('') }}"
timeout: "{{ inspection_wait_timeout }}"
when: noauth_mode is defined and noauth_mode | bool == False