openstack/bifrost
Code Issues Proposed changes

Authentication JSON RPC even in no-auth mode

Browse Source 
Also stop using deprecated HTTP basic options.

Change-Id: I5065007e30a1c8c1323e08fac24eb53d8cde19dc
This commit is contained in:
Dmitry Tantsur 2020-08-25 12:39:39 +02:00
parent 3bf9631ae5
commit 156a316926
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
playbooks/roles/bifrost-ironic-install/tasks/bootstrap.yml
View File

@ -152,7 +152,6 @@
name: "{{ admin_username }}" name: "{{ admin_username }}"
password: "{{ admin_password }}" password: "{{ admin_password }}"
when: when:
- not noauth_mode | bool
- not enable_keystone | bool - not enable_keystone | bool
- name: "Generate user htpasswd for ironic" - name: "Generate user htpasswd for ironic"

6
playbooks/roles/bifrost-ironic-install/templates/ironic.conf.j2
View File

@ -170,16 +170,10 @@ username = {{ ironic.service_catalog.username }}
password = {{ ironic.service_catalog.password }} password = {{ ironic.service_catalog.password }}
user_domain_id = default user_domain_id = default
project_domain_id = default project_domain_id = default
{% elif noauth_mode | bool %}
auth_strategy = noauth
auth_type = none
{% else %} {% else %}
auth_strategy = http_basic auth_strategy = http_basic
auth_type = http_basic auth_type = http_basic
http_basic_auth_user_file = /etc/ironic/htpasswd http_basic_auth_user_file = /etc/ironic/htpasswd
username = {{ admin_username }} username = {{ admin_username }}
password = {{ admin_password }} password = {{ admin_password }}
# Deprecated - compatibility
http_basic_username = {{ admin_username }}
http_basic_password = {{ admin_password }}
{% endif %} {% endif %}

4
releasenotes/notes/json-rpc-auth-2430cc7432cbfe10.yaml Normal file
View File

@ -0,0 +1,4 @@
---
other:
- |
Ironic JSON RPC is now always authenticated, even in no-auth mode.