openstack/bifrost
Code Issues Proposed changes

Enable inspector discovery by default

Browse Source 
In order to make lives easier, this change enables the
ironic inspector to register newly discovered nodes
that boot on the PXE network.

Change-Id: I2b4a20ecb51391c586304c0c27f660f759b349e7
This commit is contained in:
Julia Kreger 2016-10-14 17:03:01 +00:00 committed by Stephanie Miller
parent aa6c5cc4c0
commit 2786b42151
4 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
playbooks/roles/bifrost-ironic-install/README.md
View File

@ -193,6 +193,17 @@ inspector_store_ramdisk_logs: Boolean value, default true. Controls if the
inspector agent will retain logs from the inspector agent will retain logs from the
ramdisk that called the inspector service. ramdisk that called the inspector service.
enable_inspector_discovery: Boolean value, default true. This instructs
inspector to add new nodes that are discovered
via PXE booting on the same network to ironic.
inspector_default_node_driver: The default driver to utilize when adding
discovered nodes to ironic.
The default value set by bifrost is
`agent_ipmitool`. Users should change this
setting for their install environment if
an alternative default driver is required.
### Virtual Environment Install ### Virtual Environment Install
Bifrost can install ironic into a python virtual environment using the Bifrost can install ironic into a python virtual environment using the

6
playbooks/roles/bifrost-ironic-install/defaults/main.yml
View File

@ -126,6 +126,12 @@ inspector_port_addition: "pxe"
# Note: inspector_keep_ports has three valid values: all, present, added # Note: inspector_keep_ports has three valid values: all, present, added
inspector_keep_ports: "present" inspector_keep_ports: "present"
# Inspector defaults
inspector:
discovery:
enabled: "{{ enable_inspector_discovery | default(true) }}"
default_node_driver: "{{ inspector_default_node_driver | default('agent_ipmitool')}}"
# We may not have packaged iPXE files on some distros, or may want to # We may not have packaged iPXE files on some distros, or may want to
# download them on their own. # download them on their own.
download_ipxe: false download_ipxe: false

14
playbooks/roles/bifrost-ironic-install/templates/ironic-inspector.conf.j2
View File

@ -27,11 +27,9 @@ add_ports = {{ inspector_port_addition | default('pxe') }}
keep_ports = {{ inspector_keep_ports | default('present') }} keep_ports = {{ inspector_keep_ports | default('present') }}
ramdisk_logs_dir = {{ inspector_data_dir }}/log ramdisk_logs_dir = {{ inspector_data_dir }}/log
always_store_ramdisk_logs = {{ inspector_store_ramdisk_logs | default('true') | bool }} always_store_ramdisk_logs = {{ inspector_store_ramdisk_logs | default('true') | bool }}
{# {% if inspector.discovery.enabled == true %}
# Note(TheJulia): Preserving node_not_found_hook for potential future node_not_found_hook = enroll
# use by bifrost.
# The name of the hook to run when inspector receives inspection [discovery]
# information from a node it isn't already aware of. This hook is enroll_node_driver = {{ inspector.discovery.enroll_node_driver | default('fake') }}
# ignored by default. (string value) {% endif %}
#node_not_found_hook = <None>
#}

6
releasenotes/notes/enable-inspector-discovery-77aa6f5c1f1e42c6.yaml Normal file
View File

@ -0,0 +1,6 @@
---
features:
- Discovery of nodes via the ironic-inspector is now
enabled by default. If you wish to disable this, set
``enable_inspector_discovery`` to ``false`` and re-execute
the installation playbook.