openstack/bifrost
Code Issues Proposed changes

Remove explicit default from store_true

Browse Source 
The store_true action for argparse already default to False [0]

[0] https://docs.python.org/3/library/argparse.html#action

Change-Id: I2afa7068f9adc9536b4d96931fd518c065c56652
This commit is contained in:
Riccardo Pittau 2021-03-24 16:00:20 +01:00
parent 486febdf79
commit 296eba2443
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bifrost/cli.py
View File

@ -227,7 +227,7 @@ def parse_args():
install.set_defaults(func=cmd_install)
install.add_argument('--testenv', action='store_true',
help='running in a virtual environment')
install.add_argument('--develop', action='store_true', default=False,
install.add_argument('--develop', action='store_true',
help='install packages in development mode')
install.add_argument('--dhcp-pool', metavar='START-END',
help='DHCP pool to use')
@ -247,11 +247,10 @@ def parse_args():
help='a comma separated list of enabled bare metal '
'hardware types')
install.add_argument('--cleaning-disk-erase',
action='store_true', default=False,
action='store_true',
help='enable full disk cleaning between '
'deployments (can take a lot of time)')
install.add_argument('--enable-prometheus-exporter', action='store_true',
default=False,
help='Enable Ironic Prometheus Exporter')
install.add_argument('--uefi', action='store_true',
help='use UEFI by default')