openstack/bifrost
Code Issues Proposed changes

Prevent the enroll/deploy commands from running without venv

Browse Source 
Running them without sourcing the venv configuration results in a very
confusing error message from ansible. Prevent that.

Change-Id: I0cc408b475134eb76d3229b9cccefb9555b4bcba
This commit is contained in:
Dmitry Tantsur 2022-04-26 17:09:54 +02:00
parent e5f928ee46
commit 2fb9e13c02
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bifrost/cli.py
View File

@ -191,7 +191,18 @@ def cmd_install(args):
"See documentation for next steps") "See documentation for next steps")
def ensure_inside_venv():
try:
import oslo_config # noqa
except ImportError:
sys.exit("This command must be executed inside the Bifrost virtual "
"environment. Try:\n"
f" $ source {VENV}/bin/activate\n"
" $ export OS_CLOUD=bifrost")
def configure_inventory(args): def configure_inventory(args):
ensure_inside_venv()
inventory = os.path.join(PLAYBOOKS, 'inventory', 'bifrost_inventory.py') inventory = os.path.join(PLAYBOOKS, 'inventory', 'bifrost_inventory.py')
if not args.inventory: if not args.inventory:
os.environ['BIFROST_INVENTORY_SOURCE'] = 'ironic' os.environ['BIFROST_INVENTORY_SOURCE'] = 'ironic'