openstack/bifrost
Code Issues Proposed changes

Disable cleaning by default in bifrost

Browse Source 
Many initial users have encountered headaches with cleaning as it is
relatively unexpected that a deleted node suddenly becomes unusable
for a period of time while cleaning is running.

As such, we shall change the default and augment documentation to
better communicate cleaning and it's need.

Change-Id: I6a1642cbfd2ca601c5478f2868ec080a6124a3e3
This commit is contained in:
Julia Kreger 2015-07-10 10:27:07 -04:00
parent c5837dcc79
commit 320d877d73
3 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
README.rst
View File

@ -129,16 +129,18 @@ Run::
Otherwise, add -K option to let Ansible prompting for the sudo password:
ansible-playbook -K -vvvv -i inventory/localhost install.yaml
With regards to testing, you may wish to set your installation such
that ironic node cleaning is disabled. You can achieve this by passing
the option "-e cleaning=false" to the command line or executing the
command below. This is because cleaning can take a substantial amount
of time while disks are being wiped.::
With regards to testing, ironic's node cleaning capability is disabled by
default as it can be an unexpected surprise for a new user that their test
node is unusable for however long it takes for the disks to be wiped.
ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e cleaning=false
If you wish to enable cleaning, you can achieve this by passing the option
"-e cleaning=true" to the command line or executing the command below.::
ansible-playbook -K -vvvv -i inventory/localhost install.yaml -e cleaning=true
After you have performed an installation, you can edit /etc/ironic/ironic.conf
to enable or disable cleaning as desired.
to enable or disable cleaning as desired, however it is highly encouraged to
utilize cleaning in any production environment.
Manual CLI Use
--------------

4
playbooks/roles/ironic-install/README.md
View File

@ -19,9 +19,9 @@ Testing mode is intended to help facilitate testing of the Bifrost roles and Iro
testing: false
Node cleaning, which was a feature added to Ironic during the Kilo cycle, removes the previous contents of a node once it has been deleted. Bifrost sets this to true by default, however if testing mode is enabled,
Node cleaning, which was a feature added to Ironic during the Kilo cycle, removes the previous contents of a node once it has been moved from an active to available state, such as setting the provision state to deleted. Bifrost disables this by default in order to allow initial users to not be impacted by node cleaning operations upfront when they are testing and evaluating bifrost. In the event of a production deployment, cleaning should be enabled.
cleaning: true
cleaning: false
The Ironic python client and shade libraries can be installed directly from GIT. The default is to utilize pip to install the current versions in pypi, however testing may require master branch or custom patches.

2
playbooks/roles/ironic-install/defaults/main.yml
View File

@ -1,7 +1,7 @@
---
# Cleaning turns on ironic conductor clean_nodes flag
# chich causes the nodes to be wiped after deletion.
cleaning: true
cleaning: false
http_boot_folder: /httpboot
nginx_port: 8080
ironicclient_source_install: false