openstack/bifrost
Code Issues Proposed changes

Fix ansible-pip-version.py script

Browse Source 
The script uses 'isdecimal' method on strings but this is actually valid
for unicode strings only.

Cast to six.text_type before accessing this method.

Change-Id: I032f4cc90140aba4eecd4317a9cd153989ed5add
This commit is contained in:
Pavlo Shchelokovskyy 2017-02-14 16:09:48 +02:00
parent f8036dcce4
commit 37fd319ac6
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/ansible-pip-str.py
View File

@ -19,6 +19,8 @@
from __future__ import print_function
import sys
import six
in_str = sys.argv[1]
HELP_MSG = ("Unsupported version or format %s - "
"Supporting format [stable-]MAJ.MIN where MAJ.MIN is 1.9 or 2.x"
@ -27,7 +29,7 @@ HELP_MSG = ("Unsupported version or format %s - "
if in_str.startswith('stable-'):
in_version = in_str.split('stable-')[1]
else:
if in_str[0].isdecimal():
if six.text_type(in_str[0]).isdecimal():
print("ansible==%s" % in_str)
else:
print("ansible%s" % in_str)