Remove destination when doing copy_from_local_path

Otherwise we risk ending up with a mix of old and new files, which can
be seen in the upgrade CI.

Change-Id: I3d9151423d28a73bdb0f2b6cf62c8aac1d0a91b5

playbooks/roles/bifrost-create-vm-nodes/tasks/main.yml

@@ -68,6 +68,14 @@
     recurse: yes
   when: not copy_from_local_path | bool
 
+- name: remove existing requirements
+  file:
+    path: "{{ reqs_git_folder }}"
+    state: absent
+  when:
+    - copy_from_local_path | bool
+    - update_repos | bool
+
 - name: copy requirements from local path
   copy:
     src: "{{ reqs_git_url }}/"

playbooks/roles/bifrost-prep-for-install/tasks/main.yml

@@ -45,6 +45,16 @@
     - not copy_from_local_path | bool
     - item.source_install | default(true) | bool
 
+- name: "Purge existing path when copying"
+  file:
+    path: "{{ item.git_folder }}"
+    state: absent
+  loop: "{{ bifrost_install_sources }}"
+  when:
+    - copy_from_local_path | bool
+    - item.source_install | default(true) | bool
+    - update_repos | bool
+
 - name: "Copy from local path"
   copy:
     src: "{{ item.git_url }}/"

releasenotes/notes/copy-from-remove-7bcd4968a80cdbcf.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    When ``copy_from_local_path`` is used, destination path is removed on
+    upgrade before copying.