openstack/bifrost
Code Issues Proposed changes

Updated comments in bifrost-test-vm

Browse Source 
Wrapped the previous comments in the bifrost-test-vm role
and added an additional note about the future possibility
of using the inventory it's self to define the nodes.
This commit is contained in:
Julia Kreger 2015-04-01 08:34:18 -04:00
parent 6a472818c2
commit 4e17b938a0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
roles/bifrost-test-vm/tasks/main.yml
View File

@ -15,8 +15,12 @@
- name: "Execute ping step to verify connectivity and login to the host. If this fails, the configdrive may not have loaded." - name: "Execute ping step to verify connectivity and login to the host. If this fails, the configdrive may not have loaded."
ping: ping:
- name: 'Error if hostname is set to "ubuntu"' - name: 'Error if hostname is set to "ubuntu"'
# TODO: Presently this step is unable to cycle through each host and verify it's hostname is properly set. # TODO: Presently this step is unable to cycle through each host and verify
# Perhaps if there was some way to extract the data on each host from Ironic's DB and then verify that information # it's hostname is properly set. Perhaps if there was some way to extract
# the data on each host from Ironic's DB and then verify that information
# as a host-level fact that can be verified. # as a host-level fact that can be verified.
#
# TODO: As time goes on, we may move to leveraging inventory information
# which will allow this role to do validation of the remote node.
fail: msg='If this fails, the configdrive may not have been used as the hostname was set to the default "ubuntu"' fail: msg='If this fails, the configdrive may not have been used as the hostname was set to the default "ubuntu"'
when: ansible_hostname == "ubuntu" when: ansible_hostname == "ubuntu"