diff --git a/playbooks/roles/bifrost-create-vm-nodes/defaults/main.yml b/playbooks/roles/bifrost-create-vm-nodes/defaults/main.yml index 1ba484b36..a75c369d6 100644 --- a/playbooks/roles/bifrost-create-vm-nodes/defaults/main.yml +++ b/playbooks/roles/bifrost-create-vm-nodes/defaults/main.yml @@ -27,9 +27,6 @@ network_interface: "virbr0" test_vm_network: "{{ lookup('env', 'VM_NET_BRIDGE') | default('default', true) }}" test_vm_network_ip: "192.168.122.1" test_vm_network_netmask: "255.255.255.0" -test_vm_network_enable_dhcp: true -test_vm_network_dhcp_start: "192.168.122.2" -test_vm_network_dhcp_end: "192.168.122.254" test_vm_storage_pool: "{{ lookup('env', 'LIBVIRT_STORAGE_POOL') | default('default', true) }}" test_vm_storage_pool_path: "/var/lib/libvirt/images" diff --git a/playbooks/roles/bifrost-create-vm-nodes/templates/net.xml.j2 b/playbooks/roles/bifrost-create-vm-nodes/templates/net.xml.j2 index ba06f18be..0caca53ee 100644 --- a/playbooks/roles/bifrost-create-vm-nodes/templates/net.xml.j2 +++ b/playbooks/roles/bifrost-create-vm-nodes/templates/net.xml.j2 @@ -6,11 +6,5 @@ - - {% if test_vm_network_enable_dhcp | bool %} - - - - {% endif %} - + diff --git a/playbooks/roles/bifrost-ironic-install/tasks/start.yml b/playbooks/roles/bifrost-ironic-install/tasks/start.yml index 882eca65b..3fcc9e76e 100644 --- a/playbooks/roles/bifrost-ironic-install/tasks/start.yml +++ b/playbooks/roles/bifrost-ironic-install/tasks/start.yml @@ -56,14 +56,6 @@ - name: "Stop dnsmasq explicitly." service: name=dnsmasq state=stopped -# NOTE(Shrews) When testing, we want to use our custom dnsmasq.conf file, -# not the one supplied by libvirt. And the libvirt started dnsmasq processes -# are not controlled by upstart, so we need to manually kill those. -- name: "Stop existing libvirt dnsmasq processes" - command: killall -9 -w dnsmasq - when: testing | bool == true and include_dhcp_server | bool == true - ignore_errors: yes - - name: "Ensure dnsmasq is running with current config" service: name={{ item }} state=restarted enabled=yes loop: diff --git a/releasenotes/notes/test_vm_network_enable_dhcp-78923ef94b44e6d1.yaml b/releasenotes/notes/test_vm_network_enable_dhcp-78923ef94b44e6d1.yaml new file mode 100644 index 000000000..cf572e1d1 --- /dev/null +++ b/releasenotes/notes/test_vm_network_enable_dhcp-78923ef94b44e6d1.yaml @@ -0,0 +1,11 @@ +--- +fixes: + - | + Removes the ``test_vm_network_enable_dhcp`` option and disables DHCP on + the libvirt network instead of unconditionally killing all dnsmasq + processes on the machine. +upgrade: + - | + Bifrost will no longer kill all running dnsmasq processes for you. If you + have dnsmasq processes that are not managed by systemd, you have to stop + them yourself.