openstack/bifrost
Code Issues Proposed changes

playbooks: roles: {ironic,keystone}: Drop --force-reinstall

Browse Source 
setuptools seems to have some race issues when forcing a package
reinstallation with 'pip install --upgrade --force-reinstall' as
described in https://github.com/pypa/setuptools/issues/951. Until
a fixed 'pip' or 'setuptools' is released, we drop the
--force-reinstall option in order to avoid the said race.

Closes-Bug: #1667308
Change-Id: I26863dd277c7adfc1097b622069c5222b84351c7
This commit is contained in:
Markos Chandras 2017-02-22 14:58:33 +00:00
parent c3b9574c63
commit 7001a8387a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/roles/bifrost-ironic-install/tasks/install.yml
View File

@ -91,7 +91,7 @@
state=latest state=latest
sourcedir={{ ironic_git_folder }} sourcedir={{ ironic_git_folder }}
source_install=true source_install=true
extra_args="--no-cache-dir --upgrade --force-reinstall -c {{ reqs_git_folder }}/upper-constraints.txt" extra_args="--no-cache-dir --upgrade -c {{ reqs_git_folder }}/upper-constraints.txt"
when: skip_install is not defined when: skip_install is not defined
- name: "Install ironic-inspector to permit use of inspection interface" - name: "Install ironic-inspector to permit use of inspection interface"
include: inspector_install.yml include: inspector_install.yml

2
playbooks/roles/bifrost-keystone-install/tasks/pip_install.yml
View File

@ -22,6 +22,6 @@
# possibly merge these two tasks when # possibly merge these two tasks when
# https://github.com/ansible/ansible-modules-core/pull/2600 lands. # https://github.com/ansible/ansible-modules-core/pull/2600 lands.
- name: "Install from {{ sourcedir }} using pip" - name: "Install from {{ sourcedir }} using pip"
command: pip install --upgrade --force-reinstall {{ sourcedir }} command: pip install --upgrade {{ sourcedir }}
when: source_install is defined and (source_install | bool == true) when: source_install is defined and (source_install | bool == true)
environment: "{{ bifrost_venv_env if enable_venv else '{}' }}" environment: "{{ bifrost_venv_env if enable_venv else '{}' }}"