openstack/bifrost
Code Issues Proposed changes

Disable inspector discovery by default

Browse Source 
This change disables auto-discovery in ironic inspector. This will
prevent issues where accidental booting of IPA might result in
hard to debug situations where an accidentally booted IPA results
in new node(s) / port(s) added, causing conflicts.

Change-Id: I88178afd407a6339cfa42de14041c3897c3563e3
This commit is contained in:
Jacob Anders 2020-11-17 21:44:45 +10:00
parent f2fb9f0d12
commit 9258eeb228
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/roles/bifrost-ironic-install/README.md
View File

@ -224,7 +224,7 @@ inspector_store_ramdisk_logs: Boolean value, default true. Controls if the
inspector agent will retain logs from the
ramdisk that called the inspector service.
enable_inspector_discovery: Boolean value, default true. This instructs
enable_inspector_discovery: Boolean value, default false. This instructs
inspector to add new nodes that are discovered
via PXE booting on the same network to ironic.

2
playbooks/roles/bifrost-ironic-install/defaults/main.yml
View File

@ -232,7 +232,7 @@ inspector_extra_kernel_options: "ipa-inspection-collectors=default,logs"
# list of processing hooks for inspector.
#inspector_processing_hooks:
enable_inspector_discovery: true
enable_inspector_discovery: false
inspector_default_node_driver: "{{ 'manual-management' if enable_credential_less_deploy|bool else 'ipmi' }}"

6
releasenotes/notes/disable-inspector-discovery-2437e3d9b74f5258.yaml Normal file
View File

@ -0,0 +1,6 @@
---
upgrade:
- Discovery of nodes via the ironic-inspector is now
disabled by default. If you wish to enable this, set
``enable_inspector_discovery`` to ``true`` and re-execute
the installation playbook.