openstack/bifrost
Code Issues Proposed changes

Syntax changes for use of pip_install

Browse Source 
Syntax changes for consistency as follows:
- Change parameter=value syntax to parameter: value in
pip_install.yml
- Change "== false" to "| bool == false", also for
consistency.

Change-Id: I728b44243910c7c5556df529e1a3291655903883
This commit is contained in:
stephane 2015-12-21 12:51:09 -08:00
parent 288b06c441
commit b572da6804
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
playbooks/roles/bifrost-ironic-install/tasks/pip_install.yml
View File

@ -14,11 +14,12 @@
# limitations under the License. # limitations under the License.
--- ---
- name: "Install {{ package }} package from pip" - name: "Install {{ package }} package from pip"
pip: name="{{ package }}" pip:
state="{{ state | default(omit) }}" name: "{{ package }}"
version="{{ version | default(omit) }}" state: "{{ state | default(omit) }}"
virtualenv="{{ virtualenv | default(omit) }}" version: "{{ version | default(omit) }}"
when: source_install is not defined or source_install == false virtualenv: "{{ virtualenv | default(omit) }}"
when: source_install is not defined or (source_install | bool == false)
# NOTE (cinerama): We should be able to use the pip module here and # NOTE (cinerama): We should be able to use the pip module here and
# possibly merge these two tasks when # possibly merge these two tasks when
# https://github.com/ansible/ansible-modules-core/pull/2600 lands. # https://github.com/ansible/ansible-modules-core/pull/2600 lands.