openstack/bifrost
Code Issues Proposed changes

Fix deprecation warning message from Ansible

Browse Source 
Using tests as filters is deprecated. Instead of using
`result|succeeded` we should use `result is succeeded`.
This feature will be removed in Ansible version 2.9.

Change-Id: Id66444aa9757f38d40e3da36e4f27f80a707cf95
This commit is contained in:
Riccardo Pittau 2020-01-15 16:25:48 +01:00
parent e8a08bf433
commit baf8e9b64d
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playbooks/roles/bifrost-ironic-install/tasks/download_ipa_image.yml
View File

@ -54,7 +54,7 @@
# Keep downloading it until we get a good copy # Keep downloading it until we get a good copy
force: yes force: yes
register: ipa_kernel_download_done register: ipa_kernel_download_done
until: ipa_kernel_download_done|succeeded or until: ipa_kernel_download_done is succeeded or
(ipa_kernel_download_done|failed) (ipa_kernel_download_done|failed)
retries: 5 retries: 5
delay: 10 delay: 10
@ -97,7 +97,7 @@
# Keep downloading it until we get a good copy # Keep downloading it until we get a good copy
force: yes force: yes
register: ipa_ramdisk_download_done register: ipa_ramdisk_download_done
until: ipa_ramdisk_download_done|succeeded or until: ipa_ramdisk_download_done is succeeded or
(ipa_ramdisk_download_done|failed and ipa_ramdisk_download_done.status_code == 404) (ipa_ramdisk_download_done|failed and ipa_ramdisk_download_done.status_code == 404)
retries: 5 retries: 5
delay: 10 delay: 10

4
playbooks/roles/bifrost-ironic-install/tasks/get_ipxe.yml
View File

@ -30,7 +30,7 @@
dest: "{{ ipxe_dir }}/{{ item }}" dest: "{{ ipxe_dir }}/{{ item }}"
force: yes force: yes
register: ipxe_files_download_done register: ipxe_files_download_done
until: ipxe_files_download_done|succeeded until: ipxe_files_download_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
with_items: with_items:
@ -44,7 +44,7 @@
dest: "{{ ipxe_dir }}/{{ item }}" dest: "{{ ipxe_dir }}/{{ item }}"
force: yes force: yes
register: ipxe_efi_binary_download_done register: ipxe_efi_binary_download_done
until: ipxe_efi_binary_download_done|succeeded until: ipxe_efi_binary_download_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
with_items: with_items:

6
playbooks/roles/bifrost-ironic-install/tasks/pip_install.yml
View File

@ -29,7 +29,7 @@
extra_args: "{{ extra_args | default(omit) }}" extra_args: "{{ extra_args | default(omit) }}"
requirements: "{{ requirements_file | default(omit) }}" requirements: "{{ requirements_file | default(omit) }}"
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: (source_install is not defined or source_install == false) and enable_venv|bool when: (source_install is not defined or source_install == false) and enable_venv|bool
@ -42,7 +42,7 @@
extra_args: "{{ extra_args | default(omit) }}" extra_args: "{{ extra_args | default(omit) }}"
requirements: "{{ requirements_file | default(omit) }}" requirements: "{{ requirements_file | default(omit) }}"
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: (source_install is not defined or source_install == false) and not enable_venv|bool when: (source_install is not defined or source_install == false) and not enable_venv|bool
@ -53,7 +53,7 @@
- name: "Install from {{ sourcedir }} using pip" - name: "Install from {{ sourcedir }} using pip"
command: pip3 install {{ sourcedir }} {{ extra_args | default('') }} command: pip3 install {{ sourcedir }} {{ extra_args | default('') }}
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: source_install is defined and (source_install | bool == true) when: source_install is defined and (source_install | bool == true)

6
playbooks/roles/bifrost-keystone-install/tasks/pip_install.yml
View File

@ -26,7 +26,7 @@
virtualenv_command: "{{ venv_command | default(omit) }}" virtualenv_command: "{{ venv_command | default(omit) }}"
extra_args: "{{ extra_args | default(omit) }}" extra_args: "{{ extra_args | default(omit) }}"
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: (source_install is not defined or source_install == false) and enable_venv|bool when: (source_install is not defined or source_install == false) and enable_venv|bool
@ -39,7 +39,7 @@
extra_args: "{{ extra_args | default(omit) }}" extra_args: "{{ extra_args | default(omit) }}"
requirements: "{{ requirements_file | default(omit) }}" requirements: "{{ requirements_file | default(omit) }}"
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: (source_install is not defined or source_install == false) and not enable_venv|bool when: (source_install is not defined or source_install == false) and not enable_venv|bool
@ -50,7 +50,7 @@
- name: "Install from {{ sourcedir }} using pip" - name: "Install from {{ sourcedir }} using pip"
command: pip3 install --upgrade {{ sourcedir }} {{ extra_args | default('') }} command: pip3 install --upgrade {{ sourcedir }} {{ extra_args | default('') }}
register: pip_package_install_done register: pip_package_install_done
until: pip_package_install_done|succeeded until: pip_package_install_done is succeeded
retries: 5 retries: 5
delay: 10 delay: 10
when: source_install is defined and (source_install | bool == true) when: source_install is defined and (source_install | bool == true)