From d15756b32bf2b871c12dfab40cb6015dcd88a3c0 Mon Sep 17 00:00:00 2001 From: stephane Date: Thu, 18 Feb 2016 19:33:51 -0800 Subject: [PATCH] Better explanatory message for pip install Update comment text to reflect why we install pip the way we do. Change-Id: Id711b99932e5166f4ab9ce6f9d70bd8c66604ae3 Closes-Bug: #1536627 --- scripts/env-setup.sh | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/env-setup.sh b/scripts/env-setup.sh index 8b925b0d7..d749a13c5 100755 --- a/scripts/env-setup.sh +++ b/scripts/env-setup.sh @@ -82,12 +82,13 @@ PYTHON=$(which python) # We can't use the apt packaged version of pip since # older versions of pip are incompatible with # requests, one of our indirect dependencies (bug 1459947). - -# Note(TheJulia) This originally appeared because older -# versions of pip would do the wrong thing, 1459947. -# However, now pip 8.0 breaks things. See 1536627 -#wget -O /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py -#sudo -H -E python /tmp/get-pip.py +# +# Note(cinerama): We use pip to install an updated pip plus our +# other python requirements. pip breakages can seriously impact us, +# so we've chosen to install/upgrade pip here rather than in +# requirements (which are synced automatically from the global ones) +# so we can quickly and easily adjust version parameters. +# See bug 1536627. if ! which pip; then wget -O /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py