openstack/castellan
Code Issues Proposed changes

MockKeyManager create_key change key_length to length

Browse Source 
MockKeyManager was using kwarg key_length, but this is not what is
specified by the key manager interface.  The proper name for the
kward should be 'length'.

Change-Id: I3b7685363e24a9c71b9019ee94c4b2842d2a95de
This commit is contained in:
Kaitlin Farr 2016-03-28 00:00:24 -04:00
parent abf5584dd0
commit aaf8867373
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
castellan/tests/unit/key_manager/mock_key_manager.py
View File

@ -67,7 +67,7 @@ class MockKeyManager(key_manager.KeyManager):
def _generate_key(self, **kwargs):
name = kwargs.get('name', None)
algorithm = kwargs.get('algorithm', 'AES')
key_length = kwargs.get('key_length', 256)
key_length = kwargs.get('length', 256)
_hex = self._generate_hex_key(key_length)
return sym_key.SymmetricKey(
algorithm,

2
castellan/tests/unit/key_manager/test_mock_key_manager.py
View File

@ -62,7 +62,7 @@ class MockKeyManagerTestCase(test_key_mgr.KeyManagerTestCase):
def test_create_key_with_length(self):
for length in [64, 128, 256]:
key_id = self.key_mgr.create_key(self.context, key_length=length)
key_id = self.key_mgr.create_key(self.context, length=length)
key = self.key_mgr.get(self.context, key_id)
self.assertEqual(length / 8, len(key.get_encoded()))