From 5b7a823aae2b705ad3f6333ffc1c370897079d85 Mon Sep 17 00:00:00 2001
From: Aurelien Lourot <aurelien.lourot@canonical.com>
Date: Wed, 10 Feb 2021 21:43:42 +0100
Subject: [PATCH] Pin pip < 20.3

Change-Id: I27af334ab6e66646a0fbb181a1436cf399c9bef7
---
 tox.ini | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/tox.ini b/tox.ini
index fbc6f07..775ea57 100644
--- a/tox.ini
+++ b/tox.ini
@@ -7,6 +7,18 @@ skipsdist = True
 sitepackages = False
 # NOTE: Avoid false positives by not skipping missing interpreters.
 skip_missing_interpreters = False
+# NOTES:
+# * We avoid the new dependency resolver by pinning pip < 20.3, see
+#   https://github.com/pypa/pip/issues/9187
+# * Pinning dependencies requires tox >= 3.2.0, see
+#   https://tox.readthedocs.io/en/latest/config.html#conf-requires
+# * It is also necessary to pin virtualenv as a newer virtualenv would still
+#   lead to fetching the latest pip in the func* tox targets, see
+#   https://stackoverflow.com/a/38133283
+requires = pip < 20.3
+           virtualenv < 20.0
+# NOTE: https://wiki.canonical.com/engineering/OpenStack/InstallLatestToxOnOsci
+minversion = 3.2.0
 
 [testenv]
 setenv = VIRTUAL_ENV={envdir}
@@ -24,8 +36,8 @@ deps = -r{toxinidir}/test-requirements.txt
 
 [testenv:py35]
 basepython = python3.5
-deps = -r{toxinidir}/requirements.txt
-       -r{toxinidir}/test-requirements.txt
+# python3.5 is irrelevant on a focal+ charm.
+commands = /bin/true
 
 [testenv:py36]
 basepython = python3.6