openstack/charm-interface-hacluster
Code Issues Proposed changes

Use the passed arguments in remove_dnsha

Browse Source 
This appears to be a typo, where self.service_name and self.endpoint_type
was used in the same way as seen in other methods,
but self.service_name or self.endpoint_type is not defined in this class,
or any subclasses of it.
So we can use the passed name and endpoint_type arguments here.

Closes-Bug: #2037515
Change-Id: I12c561057372c11632b2d97fa1763fc92d89f479
This commit is contained in:
Samuel Walladge 2023-09-27 18:15:42 +09:30 committed by Samuel Allan
parent f3a72cdc9f
commit d91e83a1fa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
interface_hacluster/common.py
View File

@ -255,8 +255,8 @@ class ResourceManagement():
:returns: None :returns: None
""" """
res_key = 'res_{}_{}_hostname'.format( res_key = 'res_{}_{}_hostname'.format(
self.service_name.replace('-', '_'), name.replace('-', '_'),
self.endpoint_type) endpoint_type)
self.delete_resource(res_key) self.delete_resource(res_key)
def add_colocation(self, name, score, colo_resources, node_attribute=None): def add_colocation(self, name, score, colo_resources, node_attribute=None):