From 0ac4c1f18b372d9e5ee4bd6d4dcbac016ed9f764 Mon Sep 17 00:00:00 2001 From: Alex Kavanagh Date: Mon, 27 Sep 2021 10:56:14 +0100 Subject: [PATCH] Add xena bundles - add non-voting focal-xena bundle - add non-voting impish-xena bundle - rebuild to pick up charm-helpers changes - update tox/pip.sh to ensure setuptools<50.0.0 Change-Id: I96449b43c7a290cce1486f13c41cf80f6ee5fa25 --- osci.yaml | 4 ++ pip.sh | 18 +++++++++ rebuild | 2 +- src/tests/bundles/focal-xena.yaml | 65 ++++++++++++++++++++++++++++++ src/tests/bundles/impish-xena.yaml | 65 ++++++++++++++++++++++++++++++ src/tests/tests.yaml | 8 +++- src/tox.ini | 4 +- tox.ini | 17 +++++++- 8 files changed, 177 insertions(+), 6 deletions(-) create mode 100755 pip.sh create mode 100644 src/tests/bundles/focal-xena.yaml create mode 100644 src/tests/bundles/impish-xena.yaml diff --git a/osci.yaml b/osci.yaml index 14d197c..02449f9 100644 --- a/osci.yaml +++ b/osci.yaml @@ -10,8 +10,12 @@ - focal-ussuri - focal-victoria - focal-wallaby + - focal-xena: + voting: false - groovy-victoria - hirsute-wallaby + - impish-xena: + voting: false vars: needs_charm_build: true charm_build_name: keystone-kerberos diff --git a/pip.sh b/pip.sh new file mode 100755 index 0000000..9a7e6b0 --- /dev/null +++ b/pip.sh @@ -0,0 +1,18 @@ +#!/usr/bin/env bash +# +# This file is managed centrally by release-tools and should not be modified +# within individual charm repos. See the 'global' dir contents for available +# choices of tox.ini for OpenStack Charms: +# https://github.com/openstack-charmers/release-tools +# +# setuptools 58.0 dropped the support for use_2to3=true which is needed to +# install blessings (an indirect dependency of charm-tools). +# +# More details on the beahvior of tox and virtualenv creation can be found at +# https://github.com/tox-dev/tox/issues/448 +# +# This script is wrapper to force the use of the pinned versions early in the +# process when the virtualenv was created and upgraded before installing the +# depedencies declared in the target. +pip install 'pip<20.3' 'setuptools<50.0.0' +pip "$@" diff --git a/rebuild b/rebuild index 445cae0..2b0e038 100644 --- a/rebuild +++ b/rebuild @@ -2,4 +2,4 @@ # when dependencies of the charm change, # but nothing in the charm needs to. # simply change the uuid to something new -f9fbb37e-b3eb-11eb-9f92-031cf3417af3 +53c7ca20-1178-11ec-975a-bb8e7ac83d0b diff --git a/src/tests/bundles/focal-xena.yaml b/src/tests/bundles/focal-xena.yaml new file mode 100644 index 0000000..63367ca --- /dev/null +++ b/src/tests/bundles/focal-xena.yaml @@ -0,0 +1,65 @@ +variables: + openstack-origin: &openstack-origin cloud:focal-xena + +series: focal +comment: +- 'machines section to decide order of deployment. database sooner = faster' +machines: + '0': + constraints: mem=3072M + '1': + constraints: mem=3072M + '2': + constraints: mem=3072M + '3': + '4': + '5': +relations: +- - keystone:shared-db + - keystone-mysql-router:shared-db +- - keystone-mysql-router:db-router + - mysql-innodb-cluster:db-router +- - keystone + - keystone-kerberos +applications: + keystone-mysql-router: + charm: cs:~openstack-charmers-next/mysql-router + + mysql-innodb-cluster: + charm: cs:~openstack-charmers-next/mysql-innodb-cluster + num_units: 3 + options: + source: *openstack-origin + to: + - '0' + - '1' + - '2' + + keystone: + charm: cs:~openstack-charmers-next/keystone + num_units: 1 + options: + openstack-origin: *openstack-origin + token-provider: 'fernet' + token-expiration: 60 + to: + - '3' + keystone-kerberos: + charm: ../../../keystone-kerberos + options: + kerberos-realm: 'TESTUBUNTU.COM' + kerberos-server: 'kerberos.testubuntu.com' + kerberos-domain: 'k8s' + resource: + keystone_keytab: keystone.keytab + + kerberos-server: + charm: cs:~openstack-charmers-next/kerberos-test-fixture + num_units: 1 + to: + - '4' + ubuntu-test-host: + charm: cs:ubuntu + num_units: 1 + to: + - '5' diff --git a/src/tests/bundles/impish-xena.yaml b/src/tests/bundles/impish-xena.yaml new file mode 100644 index 0000000..1e20739 --- /dev/null +++ b/src/tests/bundles/impish-xena.yaml @@ -0,0 +1,65 @@ +variables: + openstack-origin: &openstack-origin distro + +series: impish +comment: +- 'machines section to decide order of deployment. database sooner = faster' +machines: + '0': + constraints: mem=3072M + '1': + constraints: mem=3072M + '2': + constraints: mem=3072M + '3': + '4': + '5': +relations: +- - keystone:shared-db + - keystone-mysql-router:shared-db +- - keystone-mysql-router:db-router + - mysql-innodb-cluster:db-router +- - keystone + - keystone-kerberos +applications: + keystone-mysql-router: + charm: cs:~openstack-charmers-next/mysql-router + + mysql-innodb-cluster: + charm: cs:~openstack-charmers-next/mysql-innodb-cluster + num_units: 3 + options: + source: *openstack-origin + to: + - '0' + - '1' + - '2' + + keystone: + charm: cs:~openstack-charmers-next/keystone + num_units: 1 + options: + openstack-origin: *openstack-origin + token-provider: 'fernet' + token-expiration: 60 + to: + - '3' + keystone-kerberos: + charm: ../../../keystone-kerberos + options: + kerberos-realm: 'TESTUBUNTU.COM' + kerberos-server: 'kerberos.testubuntu.com' + kerberos-domain: 'k8s' + resource: + keystone_keytab: keystone.keytab + + kerberos-server: + charm: cs:~openstack-charmers-next/kerberos-test-fixture + num_units: 1 + to: + - '4' + ubuntu-test-host: + charm: cs:ubuntu + num_units: 1 + to: + - '5' diff --git a/src/tests/tests.yaml b/src/tests/tests.yaml index 714583d..362ed7f 100644 --- a/src/tests/tests.yaml +++ b/src/tests/tests.yaml @@ -11,11 +11,14 @@ gate_bundles: - focal-ussuri - focal-victoria - focal-wallaby - - groovy-victoria + - focal-xena dev_bundles: - bionic-rocky + - groovy-victoria - hirsute-wallaby + - impish-xena + configure: - zaza.openstack.charm_tests.kerberos.setup.run_all_configuration_steps @@ -25,7 +28,8 @@ tests: tests_options: force_deploy: - - hirsute-wallaby + - groovy-victoria + - impish-xena target_deploy_status: keystone-kerberos: diff --git a/src/tox.ini b/src/tox.ini index e763047..b40d295 100644 --- a/src/tox.ini +++ b/src/tox.ini @@ -22,12 +22,12 @@ skip_missing_interpreters = False requires = pip < 20.3 virtualenv < 20.0 # NOTE: https://wiki.canonical.com/engineering/OpenStack/InstallLatestToxOnOsci -minversion = 3.2.0 +minversion = 3.18.0 [testenv] setenv = VIRTUAL_ENV={envdir} PYTHONHASHSEED=0 -whitelist_externals = juju +allowlist_externals = juju passenv = HOME TERM CS_* OS_* TEST_* deps = -r{toxinidir}/test-requirements.txt install_command = diff --git a/tox.ini b/tox.ini index 5c81801..22159df 100644 --- a/tox.ini +++ b/tox.ini @@ -11,6 +11,21 @@ envlist = pep8,py3 sitepackages = False # NOTE: Avoid false positives by not skipping missing interpreters. skip_missing_interpreters = False +# NOTES: +# * We avoid the new dependency resolver by pinning pip < 20.3, see +# https://github.com/pypa/pip/issues/9187 +# * Pinning dependencies requires tox >= 3.2.0, see +# https://tox.readthedocs.io/en/latest/config.html#conf-requires +# * It is also necessary to pin virtualenv as a newer virtualenv would still +# lead to fetching the latest pip in the func* tox targets, see +# https://stackoverflow.com/a/38133283 +requires = + pip < 20.3 + virtualenv < 20.0 + setuptools<50.0.0 + +# NOTE: https://wiki.canonical.com/engineering/OpenStack/InstallLatestToxOnOsci +minversion = 3.18.0 [testenv] setenv = VIRTUAL_ENV={envdir} @@ -21,7 +36,7 @@ setenv = VIRTUAL_ENV={envdir} JUJU_REPOSITORY={toxinidir}/build passenv = http_proxy https_proxy INTERFACE_PATH LAYER_PATH JUJU_REPOSITORY install_command = - pip install {opts} {packages} + {toxinidir}/pip.sh install {opts} {packages} deps = -r{toxinidir}/requirements.txt