openstack/charm-neutron-gateway
Code Issues Proposed changes

Disable vrrp healthchecks by default

Browse Source 
VRRP healthchecks were enabled by default starting in the 19.07 charm
release for network deployments which utilize l3ha or dvr+snat. The VRRP
healthchecks have specific expectations that may not be satisfied in
various data centers. This leads to problems with networks as failed
healthchecks lead to router failovers.

This change alters the default config option to disable the vrrp
healthchecks by default and require users to opt in to using them. The
description around the option has been updated to indicate that doing so
may lead to routers failing over if ICMP pings are missed.

Closes-Bug: #192101
Change-Id: Ie0ebb8072fa802dc8c2478a0b3ca38202d49c85f
This commit is contained in:
Billy Olsen 2021-03-24 15:17:25 -07:00
parent b3f6993f20
commit 5e9a7e9087
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
config.yaml
View File

@ -376,12 +376,18 @@ options:
is used with neutron. This option is ignored for Train+ OpenStack.
keepalived-healthcheck-interval:
type: int
default: 30
default: 0
description: |
By default all HA routers will check their external network gateway
by sending a ping and if that fails they trigger a vrrp transition. This
option defines how frequently this check is performed. Setting this value
to 0 will disable the healthchecks.
Specifies the frequency (in seconds) at which HA routers will check
their external network gateway by performing an ICMP ping between the
virtual routers. When the ping check fails, this will trigger the HA
routers to failover to another node. A value of 0 will disable this
check. This setting only applies when using l3ha and dvr_snat.
.
WARNING: Enabling the health checks should be done with caution as it
may lead to rapid failovers of HA routers. ICMP pings are low priority
and may be dropped or take longer than the 1 second afforded by neutron,
which leads to routers failing over to other nodes.
enable-auto-restarts:
type: boolean
default: True

2
unit_tests/test_neutron_contexts.py
View File

@ -302,7 +302,7 @@ class TestNeutronGatewayContext(CharmTestCase):
'nfg_log_output_base': None,
'nfg_log_rate_limit': None,
'ovsdb_timeout': 60,
'keepalived_healthcheck_interval': 30,
'keepalived_healthcheck_interval': 0,
})
@patch('os.environ.get')